Last modified: 2011-04-08 09:35:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30462, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28462 - Allow only specific users to review their own revisions
Allow only specific users to review their own revisions
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-08 06:40 UTC by Simon Walker
Modified: 2011-04-08 09:35 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to add codereview-review-own user right (1.83 KB, patch)
2011-04-08 06:40 UTC, Simon Walker
Details

Description Simon Walker 2011-04-08 06:40:09 UTC
Created attachment 8389 [details]
Patch to add codereview-review-own user right

Related to bug 27797

While reviewing your own code is bad practice, there are several instances I have run into on my instance of CodeReview where other people have checked code but not been bothered to mark it as OK in CodeReview.

This patch adds a new user right which by default is granted to only those in the svnadmins group. If the user has the right, it will let them mark their own revisions as OK like it did before bug 27797. If they don't, it won't have any effect on the current behaviour.

The expected use of this is to prevent users from marking their own revisions as OK, unless you're absolutely sure they already know this and won't ever mark their own revisions as OK without good reason.

This is a patch which I wrote specifically for my instance, but I'm submitting it here in case it's useful for someone else.
Comment 1 Sam Reed (reedy) 2011-04-08 09:35:16 UTC
r85668

Tweaked patch applied. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links