Last modified: 2013-01-18 21:01:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30439, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28439 - Fatal Error if logged in
Fatal Error if logged in
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
PC Windows Vista
: Low critical (vote)
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-06 11:53 UTC by BeckPotato
Modified: 2013-01-18 21:01 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description BeckPotato 2011-04-06 11:53:22 UTC
Using MediaWiki 1.16.2 on shared hosting.

Installed LiquidThreads in extensions directory, updated LocalSettings.php to run it.

When not logged in Wiki operates normally. When logged in returns: 


Fatal error: Call to a member function numRows() on a non-object in /serveraddress/html/Installdir/extensions/LiquidThreads/classes/NewMessagesController.php on line 400

I rely on Entension:MaintenanceShell to run update.php as I don't have SSH access.

Have not been able to run update.php since it requires being logged in. Not sure if this Fatal error is related to lack of updated tables or not.
Comment 1 Mark A. Hershberger 2011-04-18 20:37:56 UTC
LQT is currently being rewritten, so marking WONTFIX.  If it
happens after the rewrite, open a new bug.
Comment 2 MZMcBride 2011-04-18 20:51:02 UTC
(In reply to comment #1)
> LQT is currently being rewritten, so marking WONTFIX.  If it
> happens after the rewrite, open a new bug.

This isn't a "wontfix." Even if there were an active rewrite (which I don't believe there is), this is a legitimate bug in an actively supported, maintained, and deployed extension.
Comment 3 Mark A. Hershberger 2011-04-18 21:26:15 UTC
I don't think either of these two statements is correct, but you may
know something I don't:

“actively supported” — Is someone besides Andrew maintaining it?
    If so, I'd like to know.  Andrew has been pretty clear that he
    doesn't think it is worth his time to support LQT in its current
    form.

“maintained” — Again, is this someone besides Andrew?  Because he is
    not maintaining LQT in its current form.
Comment 4 MZMcBride 2011-04-18 21:50:53 UTC
(In reply to comment #3)
> I don't think either of these two statements is correct, but you may
> know something I don't:
> 
> “actively supported” — Is someone besides Andrew maintaining it?
>     If so, I'd like to know.  Andrew has been pretty clear that he
>     doesn't think it is worth his time to support LQT in its current
>     form.
> 
> “maintained” — Again, is this someone besides Andrew?  Because he is
>     not maintaining LQT in its current form.

Well, LiquidThreads has been around for several years and is deployed to a number of sites, including Wikimedia wikis. If support for LQTv1 is being completely dropped, it'd be nice if that were made explicit somewhere. I haven't seen anything to suggest that it is (and doing so obviously has consequences both for Wikimedia wikis and non-Wikimedia wikis).

In this case, someone has filed a bug about fatal errors popping up when they install an extension using a fairly recent version of MediaWiki. I doubt this user cares about a LiquidThreads rewrite, but I imagine they do care about having a properly working site. They've taken the time to file a bug report; it'd be nice if it weren't simply discarded.
Comment 5 Platonides 2011-04-18 23:10:07 UTC
It's not really a bug that LiquidThreads fails before being installed.

I get the cleaner error:
A database query syntax error has occurred from within function "NewMessages::newMessageCount". Database returned error "1146: Table 'user_message_state' doesn't exist (localhost)".

Your problem is needing the wiki to fix the broken wiki.

What you can do is modify LiquidThreads/classes/NewMessagesController.php
so that you add return; just below the line
static function newMessageCount( $user ) {

That will disable the checking for new messages in the yet-missing table, so you should be able to reach the MaintenanceShell extension and create the tables. Then remove the "return;" you added to restore the original functionality.
Comment 6 Andre Klapper 2012-11-06 18:20:42 UTC
BeckPotato: Did the last comment help?

With regard to the status of LiquidThreads, see http://www.mediawiki.org/wiki/Extension:LiquidThreads
Comment 7 Andre Klapper 2013-01-18 15:47:51 UTC
Unfortunately closing this report as no further information has been provided.

BeckPotato: Please feel free to reopen this report if you can provide the information asked for and if this still happens. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links