Last modified: 2011-04-06 16:32:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30422, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28422 - remove table { color: black } in Vector and Monobook
remove table { color: black } in Vector and Monobook
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.18.x
All All
: Normal minor (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-04 20:09 UTC by Fomafix
Modified: 2011-04-06 16:32 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Fomafix 2011-04-04 20:09:24 UTC
table { color: black } in
phase3/skins/monobook/main.css and
phase3/skins/vector/screen.css
is not neccessary, because Vector and Monobook defines
 div#content { color: black; }

Bug 26708 removed
 table { background-color: white }
so the default background color for tables is transparent.

At the moment tables in dark background color container are inreadable:
<div style="background-color:DarkBlue; color:white">
Table
{|
| left
| right
|}
</div>

Maybe wikitable should get
 table.wikitable { color: black }
because wikitable already has
 table.wikitable { background-color: #f9f9f9 }
Comment 1 Ryan Kaldari 2011-04-05 17:59:01 UTC
Tables have inheritance turned off by default in some browsers.
Comment 2 Fomafix 2011-04-06 08:06:18 UTC
(In reply to comment #1)
> Tables have inheritance turned off by default in some browsers.

Skin Modern has also no definition for the text color for tables.
Comment 3 Krinkle 2011-04-06 16:23:41 UTC
(In reply to comment #0)
> table { color: black } in
> phase3/skins/monobook/main.css and
> phase3/skins/vector/screen.css
> is not neccessary, because Vector and Monobook defines
>  div#content { color: black; }

Indeed.


> At the moment tables in dark background color container are inreadable:

Very true.

> Maybe wikitable should get table.wikitable { color: black }
> because wikitable already has table.wikitable { background-color: #f9f9f9 }

.wikitable nees to keep color:black because of it's backgound color, but since tables in general no longer have a background color (bug 26708) they shouldn't have a text color anymore.

Will remove black from table and add to wikitable.
Comment 4 Krinkle 2011-04-06 16:32:02 UTC
r85546

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links