Last modified: 2010-05-15 15:32:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4841, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 2841 - use of $this->loggedin inconsistant in SkinTemplate.php (with patch)
use of $this->loggedin inconsistant in SkinTemplate.php (with patch)
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks: code_quality
  Show dependency treegraph
Reported: 2005-07-13 14:28 UTC by Mark Jaroski
Modified: 2010-05-15 15:32 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Utterly trivial patch which makes the use of a member variable consistent (1.36 KB, patch)
2005-07-13 14:30 UTC, Mark Jaroski

Description Mark Jaroski 2005-07-13 14:28:51 UTC
I was digging through the code today while trying to figure out how the 
Views URLs work, and notices that while early on a member variable 
($this->loggedin) is created as ($wgUser != 0), the member variable 
isn't used consistantly.  Here's a patch that makes it consistant. 
It's absolutely trivial, doesn't actually fix any behaviour, and not 
important for me anyway, because I'm working on an extension anyhow, 
but it will be important for anybody who wants to mess with 
$this->loggedin in the future. So I thought I should take the time to 
submit it.
Comment 1 Mark Jaroski 2005-07-13 14:30:33 UTC
Created attachment 702 [details]
Utterly trivial patch which makes the use of a member variable consistent
Comment 2 Brion Vibber 2005-09-02 05:05:05 UTC
Patch doesn't apply to current code, but made similar changes in HEAD.

Note You need to log in before you can comment on or make changes to this bug.