Last modified: 2012-05-24 15:01:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 28407 - Javascript error: $j(".lqt-drop-zone").droppable is not a function
Javascript error: $j(".lqt-drop-zone").droppable is not a function
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
https://secure.wikimedia.org/wikipedi...
:
: 29205 (view as bug list)
Depends on:
Blocks: javascript
  Show dependency treegraph
 
Reported: 2011-04-03 16:32 UTC by Helder
Modified: 2012-05-24 15:01 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2011-04-03 16:32:46 UTC
When I open (logged out) a thread[1] and click on "Drag to new location" I get the following in the error console (I'm using Mozilla/5.0 (X11; U; Linux i686; pt-BR; rv:1.9.2.17pre) Gecko/20110322 Ubuntu/10.10 (maverick) Namoroka/3.6.17pre)

 $j(".lqt-drop-zone").droppable is not a function
 https://secure.wikimedia.org/w/extensions-1.17/LiquidThreads/lqt.js?301-2
 Line 1190

On Google Chrome (10.0.648.204) the error message is:
 Uncaught TypeError: Object #<Object> has no method 'droppable'
 liquidThreads.activateDragDroplqt.js:1190
 jQuery.event.handleload.php:27
 jQuery.event.add.elemData.handle.eventHandleload.php:22

This makes it impossible to use the feature.

[1] E.g.:
https://secure.wikimedia.org/wikibooks/pt/wiki/Tópico:Wikilivros:LiquidThreads/abcde?uselang=en
Comment 2 T. Gries 2011-05-29 13:35:19 UTC
I raised the error level, because this bug renders the whole Lqt unusable (in its GUI, what this extension should improve over standard talk pages), at least in the wild. 

This bug annoys users, and should -please- be fixed with a higher priority than before. I also will have a look now (since at least this bug confirms my and my wiki users observations) and try to find the problem.
Comment 3 T. Gries 2011-05-29 16:20:10 UTC
I analysed and found the same error.

the javascript 

$IP/resources/jquery.ui/jquery.ui.droppable.js

is not loaded, but needs to be loaded.
Because I do not set undertand the new method how such things are loaded, I kindly ask someone of you experts to fix that.

Perhaps, "drag to new location" works then.
Comment 4 T. Gries 2011-05-29 17:05:24 UTC
Good news: problem found. Fix will be submitted soon.
Comment 5 T. Gries 2011-05-29 17:22:28 UTC
fixed in r89102 

solution: added jquery.ui.droppable.js code to jquery.ui.dialog.js
Comment 6 Helder 2011-05-29 17:24:29 UTC
Actually, in r89120 ;-)
Comment 7 T. Gries 2011-05-29 18:45:07 UTC
reverted r89120; fixed in r89122

Index: trunk/extensions/LiquidThreads/LiquidThreads.php
===================================================================
--- trunk/extensions/LiquidThreads/LiquidThreads.php	(revision 89120)
+++ trunk/extensions/LiquidThreads/LiquidThreads.php	(revision 89121)
@@ -71,7 +71,7 @@
 $wgResourceModules['ext.liquidThreads'] = $lqtResourceTemplate + array(
 	'styles' => array( 'lqt.css', 'jquery/jquery.thread_collapse.css', 'lqt.dialogs.css' ),
 	'scripts' => array( 'lqt.js', 'js/lqt.toolbar.js', 'jquery/jquery.thread_collapse.js', 'jquery/jquery.autogrow.js' ),
-	'dependencies' => array( 'jquery.ui.dialog' ),
+	'dependencies' => array( 'jquery.ui.dialog', 'jquery.ui.droppable' ),
 	'messages' => $lqtMessages
 );
Comment 8 T. Gries 2011-05-29 18:46:20 UTC
oops, actually the bug was fixed in r89121

Index: trunk/extensions/LiquidThreads/LiquidThreads.php
===================================================================
--- trunk/extensions/LiquidThreads/LiquidThreads.php	(revision 89120)
+++ trunk/extensions/LiquidThreads/LiquidThreads.php	(revision 89121)
@@ -71,7 +71,7 @@
 $wgResourceModules['ext.liquidThreads'] = $lqtResourceTemplate + array(
 	'styles' => array( 'lqt.css', 'jquery/jquery.thread_collapse.css', 'lqt.dialogs.css' ),
 	'scripts' => array( 'lqt.js', 'js/lqt.toolbar.js', 'jquery/jquery.thread_collapse.js', 'jquery/jquery.autogrow.js' ),
-	'dependencies' => array( 'jquery.ui.dialog' ),
+	'dependencies' => array( 'jquery.ui.dialog', 'jquery.ui.droppable' ),
 	'messages' => $lqtMessages
 );
Comment 9 Andrew Garrett 2011-05-31 07:26:21 UTC
Thanks for investigating this bug — it looks like the person who converted LiquidThreads to use the resource loader made a mistake.
Comment 10 Krinkle 2011-06-03 08:14:25 UTC
*** Bug 29205 has been marked as a duplicate of this bug. ***
Comment 11 Krinkle 2012-05-24 15:01:15 UTC
*** Bug 29205 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links