Last modified: 2011-04-04 20:52:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30395, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28395 - Set forgotten parameters types in ApiParse
Set forgotten parameters types in ApiParse
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-04-02 19:26 UTC by db [inactive,noenotif]
Modified: 2011-04-04 20:52 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Fix (661 bytes, patch)
2011-04-04 13:04 UTC, Krinkle 		Details
Add an attachment (proposed patch, testcase, etc.)

Description db [inactive,noenotif] 2011-04-02 19:26:46 UTC 
Please mark action=parse&oldid and &pageid as integer, because the pageid and the oldid in MediaWiki are always integers. The pageids and revids in ApiPageSet also marked as integer. Please change the type to integer, so action=paraminfo can output that correct.

Thanks.
Comment 2 Krinkle 2011-04-04 13:06:21 UTC 
Created attachment 8373 [details]
Fix

Simple solution, not sure if there's more to it. Is there ?
Comment 3 Sam Reed (reedy) 2011-04-04 13:48:34 UTC 
(In reply to comment #2)
> Created attachment 8373 [details]
> Fix
> 
> Simple solution, not sure if there's more to it. Is there ?

That's pretty much it. But I've been tied up doing craptastic coursework over the weekened, so didn't get round to fixing these simple bugs

Just RELEASE-NOTES when you commit
Comment 4 Krinkle 2011-04-04 13:57:09 UTC 
See also https://bugzilla.wikimedia.org/show_bug.cgi?id=28394.

Will do tonight, and include in RELEASE-NOTES.
Comment 5 Sam Reed (reedy) 2011-04-04 13:57:55 UTC 
(In reply to comment #4)
> See also https://bugzilla.wikimedia.org/show_bug.cgi?id=28394.
> 
> Will do tonight, and include in RELEASE-NOTES.

Stop fixing my easy bugs! :P
Comment 6 Krinkle 2011-04-04 14:05:14 UTC 
(In reply to comment #3)
> That's pretty much it. 
> 
> Just RELEASE-NOTES when you commit

(In reply to comment #5)
> > Will do tonight, and include in RELEASE-NOTES.
> 
> Stop fixing my easy bugs! :P

You basically told me to do it! xD
Comment 7 Krinkle 2011-04-04 20:52:01 UTC 
'oldid' and 'pageid' has been set to 'integer' in r85376.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links