Last modified: 2011-07-27 22:51:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30380, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28380 - check-vars.php doesn't work only in the given directory
check-vars.php doesn't work only in the given directory
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.17.x
All All
: Normal minor (vote)
: ---
Assigned To: Platonides
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-01 23:59 UTC by Sam Reed (reedy)
Modified: 2011-07-27 22:51 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-04-01 23:59:56 UTC
reedy@ubuntu64-esxi:~/mediawiki/branches/REL1_17$ find phase3/ \( -name \*.php -or -name \*.inc \) -not \( -name importUseModWiki.php -o -name diffLanguage.php -o -name LocalSettings.php -o -name Parser?????.php \) -exec php ~/mediawiki/trunk/tools/code-utils/check-vars.php \{\} +


<snip>

Problems in phase3/includes/MessageCache.php:
 Global variable $wgContLanguageCode is not present in DefaultSettings
Problems in /home/reedy/mediawiki/trunk/tools/code-utils/../../phase3//maintenance/doMaintenance.php:
 Did not found the expected require of /home/reedy/mediawiki/trunk/tools/code-utils/../../phase3//AdminSettings.php




Errr, what?

I wanted it to target the REL1_17 branch, it seemed to use some of that, and some of trunk.

Halp?
Comment 1 Sam Reed (reedy) 2011-04-02 00:42:07 UTC
I suppose what I'm asking for, is it to be pointed at a directory, and it work from there, not hard code back to a relative path to trunk phase3 :)
Comment 2 Platonides 2011-04-04 17:31:32 UTC
You can point to the proper phase3 with the MW_INSTALL_PATH environment variable.

The files could be in trunk/phase3, in extensions or in a release branch, so picking the right folder all times could be a bit tricky.

Note however that some featured used in REL1_17 are no longer taken into account in the trunk script (eg. it now checks for RUN_MAINTENANCE_IF_MAIN, not DO_MAINTENANCE). And not even trunk is completely free of warnings.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links