Wikimedia Bugzilla is closed!

This is now in trunk at: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/Vector.php?view=annotate#l333

Does anyone know under what conditions this occurs? There would have to be someone appending to the links arrays, but not providing enough information, in this case the 'text' element.

It's easy to just case this out and call it solved, but I'm pretty sure that will only make the code more complex without addressing the actual issue, which is the abuse of the links array, probably through a hook.

If I had my 1.17 wiki working *cough*chad*cough*, I'd try and poke it

The guy had weird extensions like ExternalData and such installed...

Commenting the following line in LocalSettings.php make the error disappear.


require_once("$IP/extensions/LdapAuthentication/LdapAuthentication.php");

$wgAuth = new LdapAuthenticationPlugin();
$wgLDAPDomainNames        = array('Novell eDirectory');
$wgLDAPServerNames        = array('Novell eDirectory' => '*******');
$wgLDAPSearchAttributes   = array('Novell eDirectory' => 'uid');
$wgLDAPEncryptionType     = array('Novell eDirectory' => 'ssl');
$wgLDAPProxyAgent         = array('Novell eDirectory' => 'cn=*****');
$wgLDAPProxyAgentPassword = array('Novell eDirectory' => '*****');
$wgLDAPUseLocal           = true;

# LDAP AutoAuthentication 
require_once("$IP/extensions/LdapAuthentication/LdapAutoAuthentication.php");
$wgLDAPAutoAuthDomain = 'Novell eDirectory';
$wgLDAPAutoAuthUsername = $_SERVER["PHP_AUTH_USER"];
if ( true ) { AutoAuthSetup(); }

Furthermore, it's this hook that seem to be the root of the problem:

$wgHooks['PersonalUrls'][] = 'LdapAutoAuthentication::NoLogout'; /* Disallow logout link */

http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/LdapAuthentication/LdapAutoAuthentication.php?view=markup&pathrev=84238#l94

I hope it will help you. Best regards.

CC'ing Ryan

	/* No logout link in MW */
	static function NoLogout( &$personal_urls, $title ) {
		global $wgAuth;
		$wgAuth->printDebug( "Entering NoLogout.", NONSENSITIVE );

		$personal_urls['logout'] = null;

		return true;
	}

(In reply to comment #7)
>         $personal_urls['logout'] = null;
> 
Should use unset( $personal_urls['logout'] );  I guess

Solitarius, would you mind testing this for us?

I don't have a working Ldap setup at the moment....

Created attachment 8382 [details]
Ldap No logout patch for MW 1.17

Patch from Comment #8 from Roan

Yes, the solution work well. I'm attaching a patch so I can tag the bug.

Thanks for all your help everyone!

r85544

Seems to be only Ryan being bad

Thanks!