Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30375, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 28375 - When using existing DB user, grants aren't added to new tables

Summary:	When using existing DB user, grants aren't added to new tables

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: Installer (Other open bugs) Version: unspecified Hardware: All All Importance: Highest blocker (vote) Target Milestone: --- Assigned To: Chad H. URL: Whiteboard: Keywords: Depends on: Blocks: 26676   Show dependency tree / graph		Reported: 2011-04-01 21:08 UTC by Sam Reed (reedy) Modified: 2011-12-01 14:55 UTC (History) CC List: 3 users (show) aaron.schulz innocentkiller mah See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-04-01 21:08:28 UTC Per IRC discussion with Chad, if the DB user account already exists, the grants aren't added to the existing user <^demon> if ( !$this->getVar( '_CreateDBAccount' ) ) { <^demon> return Status::newGood(); <^demon> } Comment 1 Chad H. 2011-04-01 21:09:33 UTC Stupid mistake from when I redid all of this. Should be quick to fix (we should grant unconditionally if $wgDBuser != _InstallUser) Comment 2 Chad H. 2011-05-02 18:54:59 UTC Done in r87278.