Last modified: 2011-06-26 20:17:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30344, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28344 - Links doesn't work inside collapsible toggles
Links doesn't work inside collapsible toggles
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.20.x
All All
: Normal minor (vote)
: ---
Assigned To: Mark A. Hershberger
https://secure.wikimedia.org/wikibook...
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-31 11:50 UTC by Helder
Modified: 2011-06-26 20:17 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (814 bytes, patch)
2011-06-16 01:19 UTC, Helder
Details

Description Helder 2011-03-31 11:50:44 UTC
If a link is added inside of a collapsible toggle and a user click on it, the target page should be opened. However, in the current implementation of jQuery.makeCollapsible, a click in such links won't open the desired page. Insted, it will expand the hidden element associated to the toggle. See example in the URL above on English Wikibooks and also:
https://secure.wikimedia.org/wikipedia/meta/w/index.php?title=User_talk:Krinkle&oldid=2474984#Collapsible_tables_bugs.3F
https://secure.wikimedia.org/wikipedia/commons/wiki/MediaWiki_talk:CollapsibleTemplates.js#Links_in_header
Comment 1 Mark A. Hershberger 2011-03-31 17:47:09 UTC
Example in the URL field does demonstrate the problem, but talk page problems seem to be fixed.
Comment 2 Helder 2011-03-31 18:06:50 UTC
(In reply to comment #1)
> Example in the URL field does demonstrate the problem, but talk page problems
> seem to be fixed.

Actually it does. Maybe you've clicked in the link before the scrip was loaded?

If this information is necessary, I'm able to reproduce the problem in both
 Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

and
 IE 8.0.6001.18702
Comment 3 Mark A. Hershberger 2011-04-01 01:01:02 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Example in the URL field does demonstrate the problem, but talk page problems
> > seem to be fixed.
> 
> Actually it does.

So we agree that wikibooks URL you gave does demonstrate the problem, right?
Comment 4 Helder 2011-04-01 01:21:25 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Example in the URL field does demonstrate the problem, but talk page problems
> > > seem to be fixed.
> > 
> > Actually it does.
> 
> So we agree that wikibooks URL you gave does demonstrate the problem, right?

D'oh! My bad. I read "doesn't demonstrate" in the first time... =S

So, we indeed agree on that =)
Comment 5 Helder 2011-06-16 01:19:29 UTC
Created attachment 8667 [details]
Proposed patch

The attached patch was tested locally and fixes this bug (clicking outside the link toogles the collapsed content, and clicking on the link opens the target page).

PS: It is the same code which was used to fix the problem on Commons[1].

[1] https://secure.wikimedia.org/wikipedia/commons/w/index.php?diff=45383826&oldid=45265712
Comment 6 Mark A. Hershberger 2011-06-16 22:30:09 UTC
r90239
Comment 7 Mark A. Hershberger 2011-06-26 20:04:58 UTC
See comments on the bug + followup
Comment 8 Mark A. Hershberger 2011-06-26 20:05:18 UTC
s/bug/revision/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links