Last modified: 2012-04-16 09:15:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30343, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28343 - "Context per line" preference doesn't seem to do anything useful
"Context per line" preference doesn't seem to do anything useful
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Chad H.
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-31 06:43 UTC by Amir E. Aharoni
Modified: 2012-04-16 09:15 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2011-03-31 06:43:25 UTC
In the search preferences i can put a number in "Context per line". I tried changing it and no matter what i put there, nothing seems to change on the results page.

It it supposed to do anything at all? If it doesn't do anything on Wikipedia, then why is the preference still there?
Comment 1 Niklas Laxström 2011-03-31 17:35:09 UTC
Need to check if it is used in the default search engine or some of the search extensions like sphinx.
Comment 2 Brion Vibber 2011-04-06 22:27:23 UTC
If I'm reading this correctly, the contextchars option basically got disabled in r34210 (and contextlines earlier), when Robert was rewriting a lot of the highlighting code in 2008.

It seems to have been hardcoded at 2 lines and 75 chars, replacing the user preferences... probably we should just drop the prefs, if they've been broken for a couple years and nobody noticed!

(contextchars is also used in the ReplaceText extension, but could be dropped from there.)
Comment 3 Mark A. Hershberger 2011-04-06 23:10:09 UTC
(In reply to comment #2)
> probably we should just drop the prefs

+1

Now, where is Chad...
Comment 4 Chad H. 2011-05-01 21:14:46 UTC
Done in r87215 :D

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links