Last modified: 2011-03-31 20:45:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30331, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28331 - Dynamically replace <noscript> tags
Dynamically replace <noscript> tags
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Neil Kandalgaonkar
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-30 16:09 UTC by Bergi
Modified: 2011-03-31 20:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
noscript mode (56.87 KB, image/png)
2011-03-30 17:29 UTC, Neil Kandalgaonkar
Details

Description Bergi 2011-03-30 16:09:55 UTC
The special page should be delivered with some text (a new system message?) for users without javascript. It then would be overwritten by the script, I didn't meant a <noscript> tag in teh summary.
Comment 1 Neil Kandalgaonkar 2011-03-30 17:29:52 UTC
Created attachment 8351 [details]
noscript mode

It does have a mode for users who do not have JavaScript or choose to have it turned off. See attached screenshot.

Was something else wrong that made you think it didn't have such a feature? Or did it not work for you?
Comment 2 Bergi 2011-03-31 13:08:03 UTC
Oh, seems to be a browser bug. In Opera 11.10 noscripts tags are not shown, when javascript is disabled.
We could delete the <noscript>-tags and replace the text by JS instead, but i'll decrease the importance of this bug.
Comment 3 Mark A. Hershberger 2011-03-31 16:30:40 UTC
(In reply to comment #2)
> We could delete the <noscript>-tags and replace the text by JS instead, but
> i'll decrease the importance of this bug.

How would that solve the problem of a browser bug?  Also, are we sure this is a browser bug?  Please link to a bug report against Opera if it is.

Since <noscript> tags are supposed to be displayed if JS is turned off and they aren't displayed because of this bug, I don't see how your solution would fix the problem.  I've updated the summary, though, to reflect your requested fix, so please make sure it is what you want.  Leaning towards WONTFIX.
Comment 4 Bergi 2011-03-31 19:08:54 UTC
I thought of something like
 <div id="toRemove">$systemMessage</div>
 $('#toRemove').replaceWith(wizardDiv);
instead of
 <noscript>$systemmMessage</noscript>
 $content.append(wizardDiv);

The bug is known (http://stackoverflow.com/questions/4525009/noscript-not-working-in-opera-11), but Operas bug tracking system is private: https://bugs.opera.com/.
Comment 5 Neil Kandalgaonkar 2011-03-31 20:45:32 UTC
This is not our bug, and the impact is far too small to justify special workarounds.

This only affects users of a certain version of Opera (until it's fixed), who turn Javascript off. And the worst case scenario is that they will have to navigate to the old upload form by themselves.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links