Last modified: 2012-04-16 09:16:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30326, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28326 - UploadStash / Uploads : stashed entries not deleted, stash entry not deleted when file is
UploadStash / Uploads : stashed entries not deleted, stash entry not deleted ...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-30 09:20 UTC by Neil Kandalgaonkar
Modified: 2012-04-16 09:16 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Neil Kandalgaonkar 2011-03-30 09:20:37 UTC
In a standard Upload (as derived from UploadBase), there is an mTempPath which represents where PHP was storing the tmpnam from its upload. When the paths are initialized, it may be set to be deleted once the file is copied to the Repo.

According to the current scheme, an UploadFromStash will configure things such that the stash file is the "temporary" file, and the same thing happens. Except it's configured to not be deleted. Why?

Also, since we let the Upload delete the file in an ordinary manner, the stash entries may persist after their files are deleted. This seems wrong too. 

To fix this, we would have to get the main Upload object to invoke a delete method on UploadStash, rather than relying on the path of the UploadStash file being on the same machine, and being deletable. So that seems better for many reasons -- it's more abstract and has a better chance of working with other file stores than NFS.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links