Last modified: 2013-03-25 15:06:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30324, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28324 - merge "Disable AJAX suggestions" and "Enable enhanced search suggestions"
merge "Disable AJAX suggestions" and "Enable enhanced search suggestions"
Status: NEW
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-30 08:02 UTC by Amir E. Aharoni
Modified: 2013-03-25 15:06 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2011-03-30 08:02:19 UTC
In MediaWiki there are two preferences: "Disable AJAX suggestions" and "Enable enhanced search suggestions (Vector skin only)".

They are problematic for several reasons:

Most average users don't know what AJAX is. This word just shouldn't be there. It should be just called "search suggestions".

The first option says "Disable", but the second one says "Enable". It's confusing - both should say "Enable". "Disable AJAX suggestions" should become "Enable search suggestions", and the value of the checkbox must be reversed for all users.

But better yet, the two options should be merged into one. "Disable AJAX suggestions" doesn't seem to do anything useful in Vector, no matter whether it's checked or not, and "Enable enhanced search suggestions (Vector skin only)", as its name implies is relevant only for Vector. Separating them may have been useful in the early days of Vector, but now that a year after the rollout Vector is rather stable, this doesn't seem to be useful any more.
Comment 1 Daniel Friesen 2012-11-08 23:24:34 UTC
MWSuggest was dropped and SimpleSearch is now universal. Anyone want to double check that the change fixed this bug?
Comment 2 Krinkle 2012-11-09 10:59:35 UTC
Which of the two preference keys (not the UI label) should we preserve and should be add a step in the Updater to migrate values?

(For large clusters that don't use update.php we can use maintenance/userOptions.php)
Comment 3 Andre Klapper 2012-11-21 14:16:19 UTC
Amir: Could you answer comment 2 please?
Comment 4 Andre Klapper 2013-03-25 14:01:15 UTC
Amir: Could you answer comment 2 please?
Comment 5 Amir E. Aharoni 2013-03-25 15:06:03 UTC
(In reply to comment #2)
> Which of the two preference keys (not the UI label) should we preserve and
> should be add a step in the Updater to migrate values?

We should probably remove mwsuggest-disable completely.

Vector-simplesearch-preference should be renamed to "Enable search suggestions".

All that said, Vector-simplesearch-preference doesn't seem to have any effect: I tried unchecking it on Wikipedia and on my test wiki, and I still see search suggestions.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links