Last modified: 2014-05-16 21:07:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30299, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28299 - An image redirect from a foreign File Repo overrides local wiki page.
An image redirect from a foreign File Repo overrides local wiki page.
Status: NEW
Product: MediaWiki
Classification: Unclassified
Redirects (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-28 22:05 UTC by Bawolff (Brian Wolff)
Modified: 2014-05-16 21:07 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2011-03-28 22:05:13 UTC
Reproducible on both trunk and enwikipedia.

Steps to reproduce:
*Have some thingy thats not a redirect in the file namespace.
*Make it a redirect to some other file
*Go in the history, and look at the old (non-redirect) revision of the page.

Expected behaviour:
*You see the old version
Actual behaviour:
*You see the this page is a redirect thingy, for even the non-redirect old versions.

ImagePage.php overrides how redirects are displayed to user, and does it differently then how its normally done. Presumably there is better handling for this in Article.php. With only looking at the code for about 5 seconds, it seems like there should be a better way to do this without the duplication.

I think bug 27857 has the same root cause.


Relevant example on 'pedia: http://en.wikipedia.org/w/index.php?title=File:Bierstadt_Albert_Lower_Yellowstone_Falls.jpg&action=history

Issue originally reported by Chzz on irc.
Comment 1 Tom Brophey 2011-03-29 00:24:06 UTC
IMO, the above description does not accurately report the problem with File:Bierstadt_Albert_Lower_Yellowstone_Falls.jpg, for the associated redirect is on Commons and has only one version. Therefore it is to be expected that viewing a historic version on Wikipedia would not affect the redirect on Commons.

IMO the steps to redirect are:
*Find a redirect in File space on Commons
*Create a text-only page in File space on Wikipedia.
*Display the resulting Wikipedia page.

Expected behavior:
*The text on Wikipedia is shown in addition to (or instead of) the Commons page.
Actual behavior:
*The text on Wikipedia has no effect on the display.
Comment 2 Bawolff (Brian Wolff) 2011-03-29 03:01:50 UTC
My apologies, I misunderstood the issue. (Well actually both issues are present, but the one you're reporting seems more serious). Changing bug title to reflect actual issue.


One complication of this. Lets say [[image:foo.jpg]] is a redirect to [[image:Bar.jpg]] on commons, Someone creates the page image:Foo.jpg on enwikipedia as a normal non-redirect. Someone else puts [[image:Foo.jpg]] on an article. Since [[image:Foo.jpg]] is no longer a redirect, should inserting [[image:Foo.jpg]] into a page still display [[image:Bar.jpg]]. I'm leaning towards it shouldn't, but not really sure.
Comment 3 Tom Brophey 2011-03-29 08:42:50 UTC
(Revising comment #1)
I can’t believe I wrote that. In case it is not obvious, what I meant to say in my second paragraph was:

IMO the steps to reproduce are:
*Find a redirect in File space on Commons
*Create a text-only page in File space on Wikipedia with the same name as the redirect.
*Display the resulting Wikipedia page.
Comment 4 Mark A. Hershberger 2011-03-29 21:30:20 UTC
It appears this is an actual bug to be fixed, not an enhancement request.  reclassifying.
Comment 5 Brion Vibber 2011-04-18 19:09:01 UTC
I'm dropping this from 'highest' as it's not a huge problem, but keeping at 'high' rather than 'normal' is it sounds like it may be hard to work around for the case where it hits.
Comment 6 Brion Vibber 2011-05-03 22:41:21 UTC
Bumping back to 'normal' as nobody seems terribly freaked by it. :)
Comment 7 Nemo 2012-10-11 20:30:47 UTC
Bug 36118 is stated to be a possible duplicate.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links