Last modified: 2014-01-18 00:43:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30261, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28261 - allow list=deletedrevs&drprop=content with "deletedtext"
allow list=deletedrevs&drprop=content with "deletedtext"
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-26 20:19 UTC by db [inactive,noenotif]
Modified: 2014-01-18 00:43 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2011-03-26 20:19:17 UTC
The user right deletedtext should allow viewing of deleted content with list=deletedrevs like Special:Undelete

Thanks.
Comment 1 Sam Reed (reedy) 2011-05-20 17:55:13 UTC
What should the behaviour be if the user doesn't have deletedhistory, but has deletedtext? :/

It seems to be, Special:Undelete doesn't allow this

		$this->setHeaders();
		if ( !$this->userCanExecute( $wgUser ) ) {
			$this->displayRestrictionError();
			return;
		}


Or are you literally meaning, if they're allowed to view the history, AND they are allowed to view the text, be able to get the text as a property?
Comment 2 db [inactive,noenotif] 2011-05-20 20:42:32 UTC
the api is only checked for 'undelete' when using prop=content, but when a user has 'deletedtext' but not 'undelete' he can use the gui to see the content, but not the api.

'deletedhistory' without 'deletedtext' makes no sense, that is right.

'deletedhistory' without 'undelete' also is not allow
Comment 3 James Alexander 2013-12-18 18:46:07 UTC
Was about to file this but but seems it's already around :). It's possible it would have to be adjusted to require both deletedhistory and deletedtext but it does make sense to allow access via the api without undelete. With the principles of least access you should not have to give someone the ability to undelete the page in order to let them see deleted information. 

As an example use case (unsurprisingly from where I discovered it) a researcher may need to see deleted information and is likely to want to use the API rather then just the interface (where they can already view it without undelete). They have no need to actually undelete pages and there is no reason to let them have that ability.
Comment 4 Brad Jorsch 2013-12-23 19:30:23 UTC
I have another issue to fix first, but then I'll fix this.
Comment 5 Gerrit Notification Bot 2014-01-14 16:59:04 UTC
Change 107389 had a related patch set uploaded by Anomie:
Improve API query RevDel handling

https://gerrit.wikimedia.org/r/107389
Comment 6 Gerrit Notification Bot 2014-01-17 22:58:48 UTC
Change 107389 merged by jenkins-bot:
Improve API query RevDel handling

https://gerrit.wikimedia.org/r/107389
Comment 7 Brad Jorsch 2014-01-18 00:43:49 UTC
This change should be deployed to WMF wikis with 1.23wmf11, see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links