Last modified: 2011-03-26 21:07:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30256, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28256 - remove useless continue param from prop=info|categoryinfo|pageprops
remove useless continue param from prop=info|categoryinfo|pageprops
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-26 18:10 UTC by db [inactive,noenotif]
Modified: 2011-03-26 21:07 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description db [inactive,noenotif] 2011-03-26 18:10:13 UTC 
Without a limit param, there is no need for a continue param. Please remove the following params, because there were never added to the output:

prop=info&incontinue
prop=categoryinfo&cicontinue
prop=pageprops&ppcontinue 

Thanks.
Comment 1 Bryan Tong Minh 2011-03-26 18:27:27 UTC 
The continue fill be used if the result is too large to fit in a single response.
Comment 2 db [inactive,noenotif] 2011-03-26 20:05:44 UTC 
(In reply to comment #1)
> The continue fill be used if the result is too large to fit in a single
> response.

That is right, but it cannot be happen for that modules, because the information is always added to existing arrays inside the result.

The documentation at http://www.mediawiki.org/wiki/API:Properties#info_.2F_in also does not list this parameter.
Comment 3 Bryan Tong Minh 2011-03-26 20:28:00 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > The continue fill be used if the result is too large to fit in a single
> > response.
> 
> That is right, but it cannot be happen for that modules, because the
> information is always added to existing arrays inside the result.
> 
It's not, ApiResult::addValue takes care of that.
Comment 4 db [inactive,noenotif] 2011-03-26 21:07:56 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > The continue fill be used if the result is too large to fit in a single
> > > response.
> > 
> > That is right, but it cannot be happen for that modules, because the
> > information is always added to existing arrays inside the result.
> > 
> It's not, ApiResult::addValue takes care of that.

It is $wgAPIMaxResultSize, I have not recognize.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links