Last modified: 2012-04-16 09:15:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30254, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28254 - action=paraminfo: Extract type from PARAM_DFLT if PARAM_TYPE is not set
action=paraminfo: Extract type from PARAM_DFLT if PARAM_TYPE is not set
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
: patch, patch-reviewed
Depends on: 28702
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-26 16:44 UTC by Umherirrender
Modified: 2012-04-16 09:15 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Extract type from PARAM_DFLT if PARAM_TYPE is not set (2.08 KB, patch)
2011-03-26 16:44 UTC, Umherirrender
Details

Description Umherirrender 2011-03-26 16:44:53 UTC
Created attachment 8333 [details]
Extract type from PARAM_DFLT if PARAM_TYPE is not set

The declaration
			'unwatch' => array(
				ApiBase::PARAM_DFLT => false,
				ApiBase::PARAM_DEPRECATED => true,
			),

gives in action=paraminfo no type= and a wrong default.

<param name="unwatch" description="Remove the page from your watchlist" deprecated="" default="" />

But the default of false indicate a boolean.

The attachment change this to:

<param name="unwatch" description="Remove the page from your watchlist" deprecated="" default="false" type="bool" />

Thanks.
Comment 1 Sam Reed (reedy) 2011-03-26 19:41:25 UTC
Will look at this when I'm back on my desktop (later tonight or tomorrow)
Comment 2 Sam Reed (reedy) 2011-04-10 13:02:04 UTC
r85758

Thanks for the patch! :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links