Last modified: 2010-05-15 15:37:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2825 - "You have new messages" does not appear for anonymous users
"You have new messages" does not appear for anonymous users
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.5.x
All All
: High normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 2014
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-12 19:43 UTC by Nyenyec
Modified: 2010-05-15 15:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nyenyec 2005-07-12 19:43:06 UTC
In MediaWiki 1.5beta3 the "You have new messages" box does not appear for
anonymous users any more.

When I'm logged in I do get message notifications, but for "User
talk:XXX.XXX.XXX.XXX" (i.e. IP addresses), there is no message notification.

This used to work with 1.4.

I tested this in HuWiki and EnWiki.
Comment 1 T. Gries 2005-07-12 20:26:41 UTC
I confirm this bug in the current (CVS) version of beta3 and - unfortunately
also in my EnotifWiki version.
I'll have a look into that problem in the next hours.
Comment 2 Peter Gervai (grin) 2005-07-12 20:28:33 UTC
22:15:54 < Hashar> grin> about 70% of wikipedia traffic is from anonymous users,
we cache pages 
                   generated for them with Squid-cache
22:16:09 < Hashar> grin> so we dont want to invalidate a page for all anonymous
users when one anon 
                   receive a message :p
Comment 3 T. Gries 2005-07-12 20:29:56 UTC
I raised priority to high, because this is (in my opinion) a quite vital feature
of MediaWiki - in the Wikipedia context.
If someone is of another opinion, pls. can he or she silently decrease the
Priority ? thanks.
Comment 4 T. Gries 2005-07-12 20:31:14 UTC
(In reply to comment #2)
> 22:15:54 < Hashar> grin> about 70% of wikipedia traffic is from anonymous users,
> we cache pages 
>                    generated for them with Squid-cache
> 22:16:09 < Hashar> grin> so we dont want to invalidate a page for all anonymous
> users when one anon 
>                    receive a message :p
> 
Hashar; please can you elaborate on that ?
The feature should work, but it does not.
Comment 5 Antoine "hashar" Musso (WMF) 2005-07-12 21:10:19 UTC
Talked a bit about it with tom.
It's indeed a bug, most probably in Article::editUpdates() a case is not
handled when a user:: object is created with an ip address string.
Comment 6 T. Gries 2005-07-12 22:14:45 UTC
Article.php rev.1.355 lines 2023..2034:

perhaps, because User:newFromName($shortTitle) 
  does return 'null' (because anon isn't a validUser in newFromName() ?

I am not sure. This is, why I ask kindly:
Can someone of the core team pls. fix this ?
Comment 7 Brion Vibber 2005-07-12 22:55:34 UTC
Fixed, now creates IP users manually and it works.
Comment 8 T. Gries 2005-07-12 23:09:52 UTC
Brion,

I confirm, that your patch in Article.php
  $other = new User(); $other->setName($shortTitle);
fixed that problem.
Thanks

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links