Last modified: 2012-04-16 09:16:13 UTC
The wmf branch currently deployed on Wikimedia has broken [[Special:UploadStash]], ending in PHP fatal error in /usr/local/apache/common-local/php-1.17/includes/specials/SpecialUploadStash.php line 363: Call to undefined method HTMLForm::prepareForm() The changes which got merged in at r79129 reference HTMLForm::prepareForm(), introduced in r78425, which has not been ported to the wmf branch.
Merged the change in r84748 and sync'd it live, thanks for tracking this down :)
(In reply to comment #1) > Merged the change in r84748 and sync'd it live, thanks for tracking this down > :) OK, much better now: PHP fatal error in /usr/local/apache/common-local/php-1.17/includes/specials/SpecialUploadStash.php line 369: Call to undefined method UploadStash::listFiles() ;-)
In this case, it seems r78426 has been merged to SpecialUploadStash.php, but not to UploadStash.php in r79129… :-? Even though r78426 (nor any other upload-stash-related change) is not listed in the list of revisions allegedly merged in at r79129.
Hey there. Some context: UploadStash::listFiles() is an undocumented feature. You can invoke it by visiting the Special:UploadStash url, without any subpage url appended, e.g. http://commons.wikimedia.org/wiki/Special:UploadStash/ There are no links to this URL anywhere I am aware of. People may guess the URL by removing the file portion of certain URLs for image previews in UploadWizard. Mormegil's diagnosis seems correct, to fix it, just push the change r78426 for includes/upload/UploadStash.php. Here's the diff. r1=78425&r2=78426">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/upload/UploadStash.php?&pathrev=78426&r1=78425&r2=78426 Some pushes for UploadWizard / UploadStash are already scheduled for next week. If it's not a crisis we can wait till then.
(In reply to comment #4) > Some pushes for UploadWizard / UploadStash are already scheduled for next week. > If it's not a crisis we can wait till then. This is done now.
