Last modified: 2012-04-16 09:16:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30215, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 28215 - Unbreak Resource loader


Summary:	Unbreak Resource loader

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	ResourceLoader (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High major (vote)
Target Milestone:	---
Assigned To:	Trevor Parscal

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-03-24 05:36 UTC by srobak
Modified:	2012-04-16 09:16 UTC (History)
CC List:	10 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description srobak 2011-03-24 05:36:36 UTC

The Vector skin quit working this evening for me - no longer green on black - back to annoying & stock black on white.  Haven't changed anything, verified all my settings.  Noticed another user reported same problem in vector talk page on feb 18.

Comment 1 p858snake 2011-03-24 06:59:48 UTC

Repurposing bug since it is RL not vector broken =( see <http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Did_something_happen_to_popups.3F>

Comment 2 Derk-Jan Hartman 2011-03-24 08:22:18 UTC

Probably caused by one of these:

19:37 logmsgbot: catrope synchronized php-1.17/includes/resourceloader/ResourceLoader.php 'Bump filter cache version'
19:37 logmsgbot: catrope synchronized php-1.17/includes/libs/JavaScriptMinifier.php 'r84628'
18:34 logmsgbot: catrope synchronized php-1.17/includes/resourceloader/ResourceLoaderModule.php
18:34 logmsgbot: catrope synchronized php-1.17/includes/AutoLoader.php

Comment 3 Lupo 2011-03-24 08:52:30 UTC

The resource loader doesn't load gadgets correctly anymore. At the English Wikipedia, NavigationPopups is suddenly missing its CSS, and HotCat isn't loaded at all.

See also http://en.wikipedia.org/w/index.php?title=MediaWiki:Gadgets-definition&diff=420455530&oldid=419941286 (Change in MediaWiki:Gadgets-definition to get HotCat to load again.)

Comment 4 Bawolff (Brian Wolff) 2011-03-24 15:34:42 UTC

In my local checkout of 1.17wmf1 - issue starts appearing at r84613.

Comment 5 Roan Kattouw 2011-03-24 15:46:06 UTC

This should be fixed with r84683. It may take up to 5-10 minutes for the fix to propagate.

Comment 6 srobak 2011-03-24 17:25:34 UTC

Thanks all - seems to be working great :)

Comment 7 Helder 2011-03-25 01:51:48 UTC

I wonder if this was the cause of the problem described on IRC on last month[1], when the extension refused loading a gadget marked with [ResourceLoader] even if its contents was just [2]:

  var test = 'ok';

At that time it was necessary to remove[3] [ResourceLoader] from [[b:pt:MediaWiki:Gadgets-definition‎]], since the script wasn't being loaded at all.

After recent changes in the code (r84683 I believe) the script is loaded if the code [ResourceLoader] is added[4] to definition of the gadget.

Even if the issues were unrelated, thanks for fixing it! ;-)

[1] From [20:11:57] on: http://toolserver.org/~mwbot/logs/%23mediawiki/20110224.txt
[2] https://secure.wikimedia.org/wikibooks/pt/w/index.php/?diff=210918&oldid=210915
[3] https://secure.wikimedia.org/wikibooks/pt/w/index.php/?diff=next&oldid=210912
[4] https://secure.wikimedia.org/wikibooks/pt/w/index.php/?diff=216102&oldid=215401

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links