Last modified: 2011-03-23 19:50:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30207, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 28207 - No more JavaScript on frwiki (ResourceLoader serves invalid code)


Summary:	No more JavaScript on frwiki (ResourceLoader serves invalid code)

Status:	VERIFIED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal critical (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-03-23 19:33 UTC by Jérémie Roquet
Modified:	2011-03-23 19:50 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jérémie Roquet 2011-03-23 19:33:33 UTC

Hello,

It looks like there is a bug in ResourceLoader (or in some JavaScript minifier) that cause the valid Medawiki:Common.js of frwiki to become invalid.

Valid (at least looks like it is):
http://bits.wikimedia.org/fr.wikipedia.org/load.php?debug=true&lang=fr&modules=site&only=scripts

Invalid (sure it is not):
http://bits.wikimedia.org/fr.wikipedia.org/load.php?debug=false&lang=fr&modules=site&only=scripts

A for loop is split where it is not legal:

 for(var a=0,l=AllToggleLinks.length;a<l;a++){

becomes

 for(var a=0,l=AllToggleLinks.length;a<l;a
++){

The remaining JavaScript is of course skipped, so many things do not work anymore.

Thanks and best regards,

Comment 1 Roan Kattouw 2011-03-23 19:34:27 UTC

I swear this got fixed on trunk, looking

Comment 2 Jérémie Roquet 2011-03-23 19:35:14 UTC

Thanks.

Related discussion (in French) : http://fr.wikipedia.org/w/index.php?title=Wikipédia:Le_Bistro/23_mars_2011#Wikip.C3.A9dia_en_maintenance_.3F

Comment 3 Roan Kattouw 2011-03-23 19:39:55 UTC

(In reply to comment #1)
> I swear this got fixed on trunk, looking

It was, r83934. Deployed to the live site, this should fix itself in 5-10
minutes.

Comment 4 Jérémie Roquet 2011-03-23 19:50:20 UTC

Everything is back to normal.

Thanks a lot!

Best regards,

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links