Last modified: 2012-04-16 09:15:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30152, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28152 - Special:Preferences is not working on gu.wiki
Special:Preferences is not working on gu.wiki
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 28250 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-21 14:36 UTC by Logan Rosen
Modified: 2012-04-16 09:15 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Logan Rosen 2011-03-21 14:36:03 UTC
Special:Preferences on gu.wiki:
http://gu.wikipedia.org/wiki/Special:Preferences

It is showing an error message:
Global default '1' is invalid for field math

Backtrace:

#0 /usr/local/apache/common-local/php-1.17/includes/Preferences.php(1154): Preferences::getPreferences(Object(User))
#1 /usr/local/apache/common-local/php-1.17/includes/specials/SpecialPreferences.php(70): Preferences::getFormObject(Object(User))
#2 /usr/local/apache/common-local/php-1.17/includes/SpecialPage.php(579): SpecialPreferences->execute(NULL)
#3 /usr/local/apache/common-local/php-1.17/includes/Wiki.php(250): SpecialPage::executePath(Object(Title))
#4 /usr/local/apache/common-local/php-1.17/includes/Wiki.php(63): MediaWiki->handleSpecialCases(Object(Title), Object(OutputPage), Object(WebRequest))
#5 /usr/local/apache/common-local/php-1.17/index.php(114): MediaWiki->performRequestForTitle(Object(Title), NULL, Object(OutputPage), Object(User), Object(WebRequest))
#6 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#7 {main}
Comment 1 Yann Forget 2011-03-21 14:48:12 UTC
This only appears when using Gujarati. Preferences work when using English.
Comment 2 Roan Kattouw 2011-03-21 14:54:13 UTC
Fixed. This was caused by two of the options for the math preference having the same description:

'mw_math_simple' => 'જો સરળ હોય તો  HTML અનયથા PNG',
'mw_math_html'   => 'જો સરળ હોય તો  HTML અનયથા PNG',

I edited [[gu:MediaWiki:mw_math_simple]] to replace PNG with png so the options would be different. I'll add a warning in the message documentation that these options MUST be different, otherwise things break.
Comment 3 Max Semenik 2011-03-26 14:03:13 UTC
*** Bug 28250 has been marked as a duplicate of this bug. ***
Comment 4 Max Semenik 2011-03-26 14:04:18 UTC
Some kind soul deleted a message, and this bug resurfaced. Guess we need a more stable solution.
Comment 5 Logan Rosen 2011-03-26 19:33:33 UTC
Please note that you will not notice this bug if you do not have your language set as gu on gu.wikipedia, as it only affects that translation.
Comment 6 Dhaval 2011-03-27 12:39:09 UTC
Apologies. I had deleted [[gu:MediaWiki:mw_math_simple]] thinking it was vandalism, I now have reverted that, and the issue seems resolved. Max that (un)kind soul was me.. Apologies once again.
Comment 7 Roan Kattouw 2011-03-27 13:50:09 UTC
(In reply to comment #6)
> Apologies. I had deleted [[gu:MediaWiki:mw_math_simple]] thinking it was
> vandalism, I now have reverted that, and the issue seems resolved. Max that
> (un)kind soul was me.. Apologies once again.
You may want to check a user's global groups before you decide something is vandalism ;)

(In reply to comment #4)
> Some kind soul deleted a message, and this bug resurfaced. Guess we need a more
> stable solution.
Yes, the gu translations need to be fixed in TWN.
Comment 8 Max Semenik 2011-03-27 14:40:08 UTC
(In reply to comment #7)
> Yes, the gu translations need to be fixed in TWN.

Ideally, the whole prefs interface shoulde be changed to work as 'value' => 'ui message' instead of the other way around as we currently do it. Unfortunately, there's no clear way to do that except for a backward-incmpatible rewrite of HTMLForm. Sigh.
Comment 9 Roan Kattouw 2011-03-27 15:48:03 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > Yes, the gu translations need to be fixed in TWN.
> 
> Ideally, the whole prefs interface shoulde be changed to work as 'value' => 'ui
> message' instead of the other way around as we currently do it. Unfortunately,
> there's no clear way to do that except for a backward-incmpatible rewrite of
> HTMLForm. Sigh.

I agree that using translated strings as array keys is not nice, but the expectation that different choices for the same preference are not translated to byte-identical strings is not an unreasonable one IMO.
Comment 10 Andrew Garrett 2011-03-27 20:54:36 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > Yes, the gu translations need to be fixed in TWN.
> 
> Ideally, the whole prefs interface shoulde be changed to work as 'value' => 'ui
> message' instead of the other way around as we currently do it. Unfortunately,
> there's no clear way to do that except for a backward-incmpatible rewrite of
> HTMLForm. Sigh.

This is a deliberate design decision in HTMLForm, used to support grouped options in select boxes. In theory it could have been done differently, I suppose, but why would you want two options to be the same anyway? That's just deliberately confusing.
Comment 11 Mark A. Hershberger 2011-03-29 23:25:04 UTC
closing since the specific problem with gu.wiki is fixed.  Filed Bug #28313 against HTMLForm.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links