Last modified: 2011-03-19 19:12:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30116, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28116 - BookManager: Optimize function addText to avoid unecessary processing
BookManager: Optimize function addText to avoid unecessary processing
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
BookManager (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Raylton P. Sousa
: patch
Depends on:
Blocks: 28011
  Show dependency tree / graph
 
Reported: 2011-03-19 16:06 UTC by Helder
Modified: 2011-03-19 19:12 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
the patch... (5.84 KB, patch)
2011-03-19 16:42 UTC, Helder 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2011-03-19 16:06:04 UTC 
The current version of function addText (r84179) creates a default navigation bar with links to previous and next chapters even in cases where they won't be displayed.

The attached patch should reduce the processing of the function, returning earlier if the navigation bars will not be added and avoiding multiple identical tests of some variables ($prev, $next, BookManager). See comments on r83841. Some variables were renamed for clarity.
Comment 1 Platonides 2011-03-19 16:21:49 UTC 
There's no patch attached...
Comment 2 Helder 2011-03-19 16:42:12 UTC 
Created attachment 8314 [details]
the patch...

Uops...
Comment 3 Raylton P. Sousa 2011-03-19 19:12:43 UTC 
done in r84342
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links