Last modified: 2011-03-19 19:12:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30115, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28115 - BookManager should process the list of chapters only one time per page
BookManager should process the list of chapters only one time per page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
BookManager (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Raylton P. Sousa
: patch
Depends on:
Blocks: 28011
  Show dependency tree / graph
 
Reported: 2011-03-19 14:21 UTC by Helder
Modified: 2011-03-19 19:12 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
fix (1.38 KB, patch)
2011-03-19 14:21 UTC, Helder 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2011-03-19 14:21:41 UTC 
Created attachment 8313 [details]
fix

As of r84179, each call to pageText function causes the list of chapters of the current book to be processed in loadListFromCollection. So, if (hypothetically) a page of a book have the code
* {{PREVPAGENAME}}
* {{PREVPAGENAME}}
* {{PREVPAGENAME}}
* {{NEXTPAGENAME}}
* {{NEXTPAGENAME}}
* {{NEXTPAGENAME}}
the list of chapters will be parsed 8 times (one for each of the 2 navigation bars and another for each of the 6 uses of the magicwords).

This is unnecessary since the list doesn't change while the user is in page of a specific book.

The attached patch should fix this.
Comment 1 Raylton P. Sousa 2011-03-19 19:12:33 UTC 
done in r84342
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links