Last modified: 2012-03-24 12:22:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30105, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28105 - #set ignores $smwgLinksInValues = false
#set ignores $smwgLinksInValues = false
Status: VERIFIED INVALID
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Markus Krötzsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-18 16:42 UTC by Daniel A. R. Werner
Modified: 2012-03-24 12:22 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel A. R. Werner 2011-03-18 16:42:27 UTC
Regardingless of the state of http://www.semantic-mediawiki.org/wiki/Help:Configuration#smwgLinksInValues the functin #set allows to use links in property values, the property is always set with the link. If you use [[prop::bla [link] bla|]] instead the property won't be set if $smwgLinksInValues = false
Comment 1 Markus Krötzsch 2012-03-24 12:02:05 UTC
I do not think that this is really a bug. The parameter $smwgLinksInValues controls whether SMW should support wikitext of the form

[[Property::Foo [[Page]] Bar]]

The reason for this setting is that supporting this case makes processing for significantly less efficient (more complicated regular expressions are used). Therefore it is switched off by default. The problem is not the occurrence of links in property values; the problem is that it is hard to read the whole property value from the wikitext if one has to allow for inner "]" that are not necessarily the end of the value.

For #set, there is no such problem: the property value is always easy to retrieve and there is no extra effort in any case. If one specifies a value that contains a link, then this is what will be stored. I don't see a reason for implementing something else, especially since it would require extra effort to check for the existence of a link in a value. So it would take more computation, but its only effect would be to create errors in cases where it now just works.

Summing up: $smwgLinksInValues allows to disable an input feature for performance. It is not meant to restrict the values that properties are allowed store. There is no known use case for specifically disallowing links in property values. If the documentation should give another impression, then some clarification would be in order.
Comment 2 Daniel A. R. Werner 2012-03-24 12:22:00 UTC
The documentation just leaves the impression wikilinks in property values are a buggy feature, so one could assume this is the case for #set as well.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links