Last modified: 2011-05-03 17:12:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30080, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28080 - Add configuration option to ArticleFeedback to define namespaces where it is enabled
Add configuration option to ArticleFeedback to define namespaces where it is ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedback (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-16 21:17 UTC by Helder
Modified: 2011-05-03 17:12 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2011-03-16 21:17:28 UTC
Some wikis have its content in other namespaces besides the main namespace. E.g. English Wikibooks has a "[[b:Cookbook]]" namespace (for recipes) and Portuguese Wikipedia has an "[[pt:Anexo]]" namespace (for lists and other stuff).

As of r83924, ext.articleFeedback.startup.js has the following test:
 mw.config.get( 'wgNamespaceNumber', false ) === 0

Instead of this, the extension should check if the the current wgNamespaceNumber is in a predefined list of namespaces (configurable per wiki).
Comment 1 p858snake 2011-03-20 09:55:59 UTC
(In reply to comment #0)
> Instead of this, the extension should check if the the current
> wgNamespaceNumber is in a predefined list of namespaces (configurable per
> wiki).

"$wgContentNamespaces" might be a good fit, unless you want it to be configurable and be able to choose the namespaces yourself when its setup.
Comment 2 Helder 2011-03-20 10:43:58 UTC
(In reply to comment #1)
> "$wgContentNamespaces" might be a good fit, unless you want it to be
> configurable and be able to choose the namespaces yourself when its setup.
I think it should use $wgContentNamespaces as default value but still be configurable. This way, if some wiki wants to have feedback about its internal documentation or project pages, they could just add the necessary namespaces (as currently happens on [[wikibooks:pt:]], with ReaderFeedback - bug 26451).
Comment 3 Krinkle 2011-05-03 16:46:18 UTC
Using a global variable for this and defaulting to wgContentNamespaces sounds like a sane idea.

I'll implement this soon.
Comment 4 Krinkle 2011-05-03 17:11:24 UTC
r87336.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links