Last modified: 2011-03-15 07:23:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30053, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28053 - $wgUseCombinedLoginLink == false only shows "Log in" link when $wgShowIPinHeader==false
$wgUseCombinedLoginLink == false only shows "Log in" link when $wgShowIPinHea...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.18.x
All All
: Normal trivial (vote)
: ---
Assigned To: Simon Walker
http://prototype.helpmebot.org.uk/wik...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-15 02:32 UTC by Simon Walker
Modified: 2011-03-15 07:23 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch to fix bug (410 bytes, patch)
2011-03-15 03:07 UTC, Simon Walker 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Simon Walker 2011-03-15 02:32:44 UTC 
On a default setup, when the setting $wgUseCombinedLoginLink is set to true, the links for logging in and creating an account are combined into one single link. When this is false, they are split into two separate links, as documented.

However, when $wgShowIPinHeader is also set to false, the create account link disappears, and only the "Log in" link is visible.

I noticed this on my main wiki, http://helpmebot.org.uk/wiki/Main_Page, so I set up a test wiki at http://prototype.helpmebot.org.uk/wiki/Main_Page with nothing special in the configuration except for three items:

$wgArticlePath="/wiki/$1";
$wgUseCombinedLoginLink=false;
$wgShowIPinHeader=false;
Comment 1 Simon Walker 2011-03-15 03:07:33 UTC 
Created attachment 8297 [details]
Patch to fix bug

Here's a patch that fixes this, applied it to http://helpmebot.org.uk/w/ to test.
Comment 2 Daniel Friesen 2011-03-15 07:23:06 UTC 
Should be fixed in r84002. Best change was to just move that block out from the ipinheader condition, duplication unnecessary.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links