Last modified: 2011-03-21 18:50:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30044, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28044 - referring to global variables in messages
referring to global variables in messages
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Ryan Kaldari
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-14 17:18 UTC by Neil Kandalgaonkar
Modified: 2011-03-21 18:50 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Neil Kandalgaonkar 2011-03-14 17:18:45 UTC
For the tooltips in UploadWizard, in one case we now have a global variable encoded in the message:

'mwe-upwiz-tooltip-title' => 'A short unique title for the file. You may use plain language with spaces. Do not include the file extension. <a target="_blank" onclick="\\$titleDialog.dialog(\'open\');return false;" href="#">Learn more</a>.',

This is obviously nasty because
- global variable!
- it's in a message!

This sort of thing shouldn't be necessary -- it's happening for two reasons.

- as a way of hacking in a link with JS behaviour into a message -- this is easy to do with the new .msg() feature, though

- tipsy.js relies only on info shoved into the "title" attr, which has to be a string. If it retrieved info from .data() we wouldn't have that limitation.
Comment 1 Ryan Kaldari 2011-03-21 18:50:05 UTC
Neil fixed this.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links