Last modified: 2011-03-13 22:58:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30031, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28031 - Add pageCount support to ArchivedFile
Add pageCount support to ArchivedFile
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks: 27585
  Show dependency tree / graph
 
Reported: 2011-03-13 22:46 UTC by Sam Reed (reedy)
Modified: 2011-03-13 22:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Attempt numero uno (1.40 KB, patch)
2011-03-13 22:48 UTC, Sam Reed (reedy) 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-03-13 22:46:36 UTC 
Seems we have requests for this information (yay)... Can we add it?

Want to effectively do ArchivedFile::newFromRow( $row )->pageCount();

Thanks :)
Comment 1 Sam Reed (reedy) 2011-03-13 22:48:52 UTC 
Created attachment 8288 [details]
Attempt numero uno
Comment 2 Sam Reed (reedy) 2011-03-13 22:52:09 UTC 
<Bryan> Reedy: ehh, isn't ArchivedFile::pageCount() just working?
<Bryan> it's inherited from File
<Reedy> Bryan, class ArchivedFile {
<Reedy> It seemed rather strange :/
<Intima> It sure does
<Bryan> wtf
* Reedy runs away
<Bryan> it can at least inherit File, but possibly LocalFile as well

Leaving as is for the moment... The patch would fix it, but if we're just going to add in a super class, this patch is redundant
Comment 3 Bryan Tong Minh 2011-03-13 22:53:39 UTC 
(In reply to comment #2)
> Leaving as is for the moment... The patch would fix it, but if we're just going
> to add in a super class, this patch is redundant


It's good enough for now though.
Comment 4 Sam Reed (reedy) 2011-03-13 22:58:50 UTC 
r83861
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links