Last modified: 2011-03-14 09:28:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30029, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28029 - BookManager: Navigation bar should be added only to pages which are part of some book
BookManager: Navigation bar should be added only to pages which are part of s...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
BookManager (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Raylton P. Sousa
:
Depends on:
Blocks: 28011
  Show dependency treegraph
 
Reported: 2011-03-13 15:20 UTC by Helder
Modified: 2011-03-14 09:28 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2011-03-13 15:20:37 UTC
Currently if a wiki has a page "Example" which is not in the list of chapters of any book (e.g. because it is a disambiguation page, or just a page which was created without being a chapter of a book), the extension still adds the navigation bar to it.

This shouldn't happen. It should check if the page is in some book (specifically if it is in the list of chapters corresponding to the base page name), and do not add the navigation if the page is not one chapter of the book.

An example is found in the image attached to Bug 28027:
http://bug-attachment.wikimedia.org/attachment.cgi?id=8287
The page "Teste/!" is not part of any book (there is no book "Teste" in the wiki), but we still see the navigation there.
Comment 1 Raylton P. Sousa 2011-03-13 17:47:08 UTC
fix in r83841

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links