Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30001, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 28001 - Invalid argument supplied for foreach() in /usr/local/apache/common-local/php-1.17/extensions/Collection/Collection.suggest.php on line 136

Summary:	Invalid argument supplied for foreach() in /usr/local/apache/common-local/php...

Status: RESOLVED FIXED Product: MediaWiki extensions Classification: Unclassified Component: Collection (Other open bugs) Version: unspecified Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: PediaPress Development Team URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2011-03-12 10:52 UTC by Domas Mituzas Modified: 2011-03-12 16:36 UTC (History) CC List: 1 user (show) johannes.beigel See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Domas Mituzas 2011-03-12 10:52:32 UTC Collection seems to hit an "invalid argument" warning on 1.17: Mar 12 10:50:26 10.0.2.210 apache2[18010]: PHP Warning: Invalid argument supplied for foreach() in /usr/local/apache/common-local/php-1.17/extensions/Collection/Collection.suggest.php on line 136 Comment 1 Sam Reed (reedy) 2011-03-12 13:10:22 UTC $bans = $_SESSION['wsCollectionSuggestBan']; $newbans = array(); foreach ( $bans as $ban ) { Looks like they don't check that index in session variable is properly set.. Comment 2 Johannes Beigel 2011-03-12 16:36:24 UTC Thanks for the pointer. I've fixed it in r83764.