Last modified: 2011-05-03 16:42:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30000, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28000 - [ClickTracking] Missing argument 12 for ClickTrackingHooks::articleSaveComplete() warnings
[ClickTracking] Missing argument 12 for ClickTrackingHooks::articleSaveComple...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-12 10:50 UTC by Domas Mituzas
Modified: 2011-05-03 16:42 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Domas Mituzas 2011-03-12 10:50:20 UTC
We have plethora of warnings in our cluster:


Mar 12 10:48:00 10.0.2.228 apache2[24553]: PHP Warning:  Missing argument 12 for ClickTrackingHooks::articleSaveComplete() in /usr/local/apache/common-local/php-1.17/extensions/ClickTracking/ClickTracking.hooks.php on line 176
Mar 12 10:48:00 10.0.8.22 apache2[10959]: PHP Warning:  Missing argument 12 for ClickTrackingHooks::articleSaveComplete() in /usr/local/apache/common-local/php-1.17/extensions/ClickTracking/ClickTracking.hooks.php on line 176
Comment 1 Domas Mituzas 2011-03-12 11:40:17 UTC
I synced this live, and committed into wmf-deployment as r83749


Index: ClickTracking.hooks.php
===================================================================
--- ClickTracking.hooks.php	(revision 83735)
+++ ClickTracking.hooks.php	(working copy)
@@ -173,7 +173,7 @@
 	}
 	
 	public static function articleSaveComplete( $article, $user, $text, $summary, $minoredit,
-			$watchthis, $sectionanchor, $flags, $revision, $status, $baseRevId, $redirect ) {
+			$watchthis, $sectionanchor, $flags, $revision, $baseRevId ) {
 		self::trackRequest( 'save-complete' );
 		return true;
 	}
Comment 2 Krinkle 2011-05-03 16:42:26 UTC
r83898 by catrope at 14:34, 14 March 2011
> ClickTracking: Merge r83749 from 1.17wmf1 to trunk

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links