Last modified: 2012-10-12 01:38:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29999, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27999 - add getCallStack() function to mediawiki.log
add getCallStack() function to mediawiki.log
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-unittest, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-12 00:49 UTC by Michael Dale
Modified: 2012-10-12 01:38 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
adds mw.getCallStack to mediaWiki.log (2.05 KB, patch)
2011-03-12 00:50 UTC, Michael Dale
Details

Description Michael Dale 2011-03-12 00:49:47 UTC
This is helpful for tracing errors when we put in lots of try catch handling that does not show browser native call stacks on global exceptions.
Comment 1 Michael Dale 2011-03-12 00:50:27 UTC
Created attachment 8283 [details]
adds mw.getCallStack to mediaWiki.log
Comment 2 Michael Dale 2011-03-12 01:02:31 UTC
also mw.getCallStack is helpful for debugging mysterious iOS errors that occur  when you hit the device call stack limit of 100 ( other browsers have 1000+ )
Comment 3 Krinkle 2011-03-12 01:26:11 UTC
See also bug 27890
Comment 4 p858snake 2011-04-30 00:09:48 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 5 Bugmeister Bot 2011-08-19 19:12:58 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 6 Sumana Harihareswara 2012-05-25 02:56:11 UTC
Michael, do you want to submit this into Git?
Comment 7 Krinkle 2012-05-25 04:09:59 UTC
This also needs unit tests. And for the follow-up: Check the code conventions (mostly whitespace and a few other details).
Comment 8 Michael Dale 2012-05-25 08:01:42 UTC
yea... I don't really use this any more. I generally just comment out the try catch wrappers that hide the native browser callstack when I need to debug such things, and generally know what to look for / avoid in terms of iOS stack overflows

I would instead recommend "debug" / "develop" mode does not use whole resource try catches, but understandable if that deviates too much from non-debug mode. In which case you can just as easy remove the try catches when you need to.
Comment 9 Sumana Harihareswara 2012-10-12 01:38:33 UTC
Based on comment #8 I'm closing this issue. Thanks, Michael.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links