Last modified: 2013-12-29 06:58:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29983, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27983 - Special:NewMessages should be paginated
Special:NewMessages should be paginated
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: High minor (vote)
: ---
Assigned To: Roan Kattouw
: patch
Depends on:
Blocks: 29090
  Show dependency treegraph
 
Reported: 2011-03-10 22:44 UTC by Emufarmers
Modified: 2013-12-29 06:58 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Provisional merge of r72707, r72708, r72807, r72812 (11.53 KB, patch)
2011-04-27 18:25 UTC, Brion Vibber
Details

Description Emufarmers 2011-03-10 22:44:21 UTC
Special:NewMessages is presently unpaginated; for people who let their messages accumulate into the thousands (don't judge us!), the page will eventually become big enough to choke a browser (and long before that, it will stop being useful).
Comment 1 Niklas Laxström 2011-03-11 20:23:36 UTC
Where do you see this? I know for certain that this is fixed in trunk.
Comment 2 Emufarmers 2011-03-12 00:45:05 UTC
MediaWiki.org
Comment 3 Brion Vibber 2011-04-09 20:51:17 UTC
Mine doesn't even render; the page just times out (over 3700 messages).


At least once I eventually got this:

Database error
A database query syntax error has occurred. This may indicate a bug in the software. The last attempted database query was:

    (SQL query hidden)

from within function "User::invalidateCache". Database returned error "1205: Lock wait timeout exceeded; try restarting transaction (10.0.6.49)".
Comment 4 Niklas Laxström 2011-04-10 06:30:17 UTC
Should we reclassify this to WMF product?
Comment 5 p858snake 2011-04-10 06:32:11 UTC
It's possibly Invalid, we probably aren't running a updated lqt on the wmf cluster.
Comment 6 Brion Vibber 2011-04-27 18:08:51 UTC
Seems to have been done last September on trunk, in r72707 and friends (which is tagged 1.18). Has not been merged for 1.17 or deployment.

This is still blocking me from reading messages on www.mediawiki.org: now up to 4,844 unread messages.
Comment 7 Brion Vibber 2011-04-27 18:25:41 UTC
Created attachment 8470 [details]
Provisional merge of r72707, r72708, r72807, r72812

Attached a provisional patch that's a direct merge of r72707, r72708, r72807, r72812 from trunk to 1.17wmf1.

This applies cleanly, but doesn't seem to work properly: Special:NewMessages doesn't show any threads for me with the patch on 1.17wmf1, while it's fine on trunk. There might be some other related things it needs that should also be merged.

Note that there's a schema change in this set, adding ums_conversation and adjusting an index on the thread table. May require ops coordination to roll out.
Comment 8 Mark A. Hershberger 2011-04-28 20:12:46 UTC
Giving the bug to Roan since, looking at CR comments, he is already on of it.
Comment 9 p858snake 2011-04-30 00:10:04 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 10 Andrew Garrett 2011-05-22 12:47:30 UTC
(In reply to comment #7)
> Created attachment 8470 [details]
> Provisional merge of r72707, r72708, r72807, r72812
> 
> Attached a provisional patch that's a direct merge of r72707, r72708, r72807,
> r72812 from trunk to 1.17wmf1.
> 
> This applies cleanly, but doesn't seem to work properly: Special:NewMessages
> doesn't show any threads for me with the patch on 1.17wmf1, while it's fine on
> trunk. There might be some other related things it needs that should also be
> merged.
> 
> Note that there's a schema change in this set, adding ums_conversation and
> adjusting an index on the thread table. May require ops coordination to roll
> out.

I believe you'll need to pre-populate the ums_conversation field. The supplied patch file should do this for you.
Comment 11 Krinkle 2011-05-22 12:50:39 UTC
Marking FIXED per Brion's change to the bug summary late April 2011.

Bug 29090 for if and how we would pre-deploy this on WMF (or wait for the deployment of the finished rewrite in 1.18/1.19/1.20)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links