Last modified: 2011-03-11 00:14:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29979, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27979 - second argument in mw.loader's resolve() is redefined before used
second argument in mw.loader's resolve() is redefined before used
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: High enhancement (vote)
: ---
Assigned To: Trevor Parscal
http://svn.wikimedia.org/viewvc/media...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-10 18:30 UTC by Krinkle
Modified: 2011-03-11 00:14 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2011-03-10 18:30:35 UTC
On line 605:
				var resolved = [];

The resolved variable is redefined but it was (and is) never used.

There's also no call to the resolve() function anywhere with more than 1 argument, for that reason I haven't touched this yet since I'm not 100% sure what it's supposed to do.

I'm guessing a callback function, but then agian, it's not used nor called anywhere...
Comment 1 Trevor Parscal 2011-03-11 00:14:30 UTC
Fixed in r83680. The 2nd and 3rd argument are indeed never used for resolve, nor were they documented. Simply removing them is all that was needed. This was an artifact of splitting recurse and resolve, most likely a copy-past oversight. Since the arguments were never used it didn't cause any errors, but did give the code that mysterious feel. :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links