Last modified: 2011-10-01 03:14:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29967, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27967 - wikis with $wgRawHtml = TRUE can no longer use jQuery in wikitext
wikis with $wgRawHtml = TRUE can no longer use jQuery in wikitext
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Highest normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-10 00:23 UTC by Ryan Kaldari
Modified: 2011-10-01 03:14 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2011-03-10 00:23:10 UTC
Wikis like wikimediafoundation.org and payments.wikimedia.org allow the use of javascript in wikitext - for things like dynamic forms and fundraising thermometers. Now that jQuery isn't loaded until the end of the page, however, all the jQuery pieces are broken. Obviously, there are several workarounds available, but I would like to argue for including jQuery in the head if $wgRawHtml = TRUE. It's only 100K of overhead and having it available for wikitext seems like a very useful feature--maybe not for most foundation wikis, but for intranet and private wikis especially.

Would it be difficult to add in a switch so that jQuery was included in the head if $wgRawHtml = TRUE?
Comment 1 Tim Starling 2011-03-28 23:36:05 UTC
Maybe we could have a separate setting for that, instead of just doing it when $wgRawHtml is on?
Comment 2 Ryan Kaldari 2011-03-28 23:49:28 UTC
Trevor has also mentioned that there is a possibility that jQuery will be moved back to the head anyway. Which would make this bug moot.
Comment 3 Ryan Kaldari 2011-05-09 22:59:41 UTC
Fundraising is gearing up for workflow testing, so we need to know if this bug is going to be fixed in the near future or not. If not, we to start re-coding all the pages currently using jQuery in wikitext.
Comment 4 Roan Kattouw 2011-05-14 09:37:01 UTC
This is fixed in trunk, because jQuery is back in the <head>
Comment 5 Ryan Kaldari 2011-09-30 01:56:56 UTC
Looks like this didn't make it into the final 1.17.0 release, which puts us back in the same boat for fundraising. Any chance of a 1.17.1 release? We'd rather not run development code on the payments server.
Comment 6 Roan Kattouw 2011-09-30 10:53:23 UTC
(In reply to comment #5)
> Looks like this didn't make it into the final 1.17.0 release, which puts us
> back in the same boat for fundraising. Any chance of a 1.17.1 release? We'd
> rather not run development code on the payments server.
Hmm. It is in 1.17wmf1, 1.18 and 1.18wmf1. Surely you'd feel comfortable running code that has been running on the live site for half a year (1.17wmf1)? :)
Comment 7 Ryan Kaldari 2011-09-30 23:34:21 UTC
Fair enough. We'll upgrade to 1.17wmf1 rather than 1.17.0. Thanks for the advice.
Comment 8 p858snake 2011-09-30 23:47:38 UTC
May as well go to 1.18wmf1 since the rest of the cluster is going to be running it in about a week.
Comment 9 James Alexander 2011-09-30 23:52:44 UTC
We'll probably hold off on 1.18 for the fundraiser. It's a bit of a process to update and we've held off 'bleeding edge' and new deployments for hidden gotchas or security holes that could cause issues and then take a while to port over, test with the fundraising infrastructure and deploy.
Comment 10 p858snake 2011-10-01 03:14:44 UTC
(In reply to comment #9)
> We'll probably hold off on 1.18 for the fundraiser. It's a bit of a process to
> update and we've held off 'bleeding edge' and new deployments for hidden
> gotchas or security holes that could cause issues and then take a while to port
> over, test with the fundraising infrastructure and deploy.
As for the security holes, You might actually be at a disadvantage after this week when the last projects are pushed to 1.18wmf1, because not much (if any) attention will be payed to 1.17wmf1 due to almost no one using it (It's not recommended for people to use this outside WMF but a small number do/have) and I don't think anyone will spend that much time backporting fixes to it when its not really being used/supported on the cluster for the projects.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links