Last modified: 2011-03-09 14:02:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29944, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27944 - 'Search' placeholder is inserted even if search field already has focus
'Search' placeholder is inserted even if search field already has focus
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
1.17.x
All All
: Normal normal (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-08 22:43 UTC by Ryan Kaldari
Modified: 2011-03-09 14:02 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2011-03-08 22:43:09 UTC
If you click in the search field before the 'Search' placeholder text is inserted (which is quite easy now in 1.17), it still inserts the placeholder text in Firefox. At that point it treats 'Search' as the text you are searching for.

This doesn't seem to occur in Safari
Comment 1 Ryan Kaldari 2011-03-08 22:45:10 UTC
This seems to also occur in some mobile browsers.
Comment 2 Krinkle 2011-03-08 22:46:44 UTC
Basically any browser that does not support placeholder natively and triggers the fallback.
Comment 3 Ryan Kaldari 2011-03-08 22:50:34 UTC
Also, Explorer 7, changing bug title...
Comment 4 Roan Kattouw 2011-03-09 14:02:03 UTC
Fixed in r83586 by removing the placeholder as soon as anything (keydown, paste, drop) happens in the text box. This means that, if the search box is focused before the placeholder plugin runs, the placeholder will still be inserted, but it'll be removed once you start typing, so the placeholder text will no longer be added to your search query.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links