Last modified: 2012-07-23 13:25:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29918, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27918 - Enable patrolled edits on Hebrew Wikibooks
Enable patrolled edits on Hebrew Wikibooks
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-07 17:04 UTC by Crazy Ivan
Modified: 2012-07-23 13:25 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Crazy Ivan 2011-03-07 17:04:03 UTC
Please enable patrolled edits on Hebrew Wikibooks, including patroller and autopatrolled user groups.

Community discussion is here: [[B:he:ויקיספר:מזנון#מערכת בקרת שינויים]]

Thank you.
Comment 1 Antoine "hashar" Musso (WMF) 2011-03-10 21:19:10 UTC
Should be fixed now:

Index: InitialiseSettings.php
===================================================================
--- InitialiseSettings.php	(revision 1603)
+++ InitialiseSettings.php	(working copy)
@@ -5680,6 +5680,10 @@
 	    'patroller' => array( 'patrol' => true, 'autopatrol' => true, 'unwatchedpages' => true, 'rollback' => true, ),
 	    'autopatrolled' => array( 'autopatrol' => true ),
     ),
+    'hewikibooks' => array(
+    	'patroller' => array( 'patrol' => true ),  # bug 27918
+    	'autopatrolled' => array( 'autopatrol' => true ), # bug 27918
+    ),
     'hiwiki' => array(
 	    'confirmed' => array( 'upload' => true, 'patrol' => true ),
 	    'rollbacker' => array( 'rollback' => true ),
@@ -6200,6 +6204,9 @@
     '+hewiki' => array(
 		'sysop' => array( 'patroller', 'autopatrolled' ),
     ),
+    '+hewikibooks' => array(
+		'sysop' => array( 'patroller', 'autopatrolled' ),
+    ),
     '+hiwiki' => array(
 	    'bureaucrat' => array( 'interface_editor', 'flood', 'abusefilter', 'eliminator', 'import', 'transwiki', 'accountcreator' ),
 	    'sysop' => array( 'confirmed', 'rollbacker', 'autopatrolled', 'editprotected', 'patroller', ),
@@ -6485,6 +6492,9 @@
     '+hewiki' => array(
 		'sysop' => array( 'patroller', 'autopatrolled' ),
     ),
+    '+hewikibooks' => array(
+		'sysop' => array( 'patroller', 'autopatrolled' ),
+    ),
     '+hiwiki' => array(
 	    'bureaucrat' => array( 'sysop', 'interface_editor', 'flood', 'abusefilter', 'eliminator', 'import', 'transwiki', 'accountcreator' ),
 	    'sysop' => array( 'confirmed', 'rollbacker', 'autopatrolled', 'editprotected', 'patroller', ),
Comment 2 Crazy Ivan 2011-03-11 09:44:50 UTC
(In reply to comment #1)
> Should be fixed now:

Thank you, but it doesn't work: edits made by users without permissions don't appear as "unpatrolled" in the recent changes.
Comment 3 Antoine "hashar" Musso (WMF) 2011-03-12 11:52:41 UTC
Your change has been completed.
Please reopen this ticket if anything went wrong.
The following configuration settings have been changed:
===================================================================
Index: InitialiseSettings.php
===================================================================
--- InitialiseSettings.php	(revision 1606)
+++ InitialiseSettings.php	(working copy)
@@ -5681,7 +5681,7 @@
 	    'autopatrolled' => array( 'autopatrol' => true ),
     ),
     'hewikibooks' => array(
-    	'patroller' => array( 'patrol' => true ),  # bug 27918
+    	'patroller' => array( 'patrol' => true, 'patrolmarks' => true ),  # bug 27918
     	'autopatrolled' => array( 'autopatrol' => true ), # bug 27918
     ),
     'hiwiki' => array(
===================================================================
You can find the entire config file at
http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php
Comment 4 Antoine "hashar" Musso (WMF) 2011-03-12 11:53:51 UTC
the right 'patrolmarks' is required to see the red esclamation marks. I have added the rights to the patroller group.  Let me know if you want it added to everyone instead.
Comment 5 Aaron Schulz 2011-11-09 20:03:51 UTC
(In reply to comment #4)
> the right 'patrolmarks' is required to see the red esclamation marks. I have
> added the rights to the patroller group.  Let me know if you want it added to
> everyone instead.

That right is only needed if you don't have 'patrol' but want to see the '!' marks.
Comment 6 Crazy Ivan 2011-11-12 11:49:07 UTC
Sorry for my late comment, I wasn't active in Hebrew Wikibooks in the recent months.

I reopened this bug because it is still not possible to see the '!' marks and to mark edits as patrolled.

Sysops and patrollers are supposed to see the '!' marks and be able to mark edits as patrolled. These user groups have the 'patrol' right, so I don't know what is the problem.

In addition, patrollers should get the 'autopatrol' right.
Comment 7 Crazy Ivan 2011-12-01 19:06:53 UTC
A more precise diagnosis: The '!' marks appear only when a new page is created. It doesn't appear when an existing page is edited.
Comment 8 matanya 2012-07-22 19:30:08 UTC
yes, still an issue. waiting for a patch.
Comment 9 Alex Monk 2012-07-22 19:30:57 UTC
Sorry for the ridiculous amount of time it's taken to solve this bug. I've just been made aware of it by a steward.

After checking through the MW core source, it looks like Hashar forgot to enable wgUseRCPatrol on that wiki. (Or maybe it didn't exist at the time? I don't know.)

Gerrit change #16267
Comment 10 Alex Monk 2012-07-23 12:50:30 UTC
This should now be fixed.
Comment 11 matanya 2012-07-23 13:25:26 UTC
Thanks, it works.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links