Last modified: 2013-01-08 00:01:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29885, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27885 - limit>0 query fail to produce proper links.
limit>0 query fail to produce proper links.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Jeroen De Dauw
: patch, patch-need-review
: 27638 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-06 06:24 UTC by John Morton
Modified: 2013-01-08 00:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Limit>0 link fix. (1.82 KB, patch)
2011-03-06 06:24 UTC, John Morton
Details

Description John Morton 2011-03-06 06:24:01 UTC
Created attachment 8254 [details]
Limit>0 link fix.

Setting the limit parameter less than zero should produce only a “further results” link to a similar query via Special:Ask, however there are two problems:

1) The resulting link is missing most of the parameters of the original inline query.

2) Several result formats in the SemanticResultFormat extension override the getResult method from SMWResultPrinter in order to still print output even if there are no results, however they do so at the expense of the negative limit link feature, as well as a collection of other error handling code.

The attached patch fixes both problems:

1) All parameters are added to the link. The limit is flipped to positive.

2) An additional argument is added to getResult for printing zero result queries which defaults to false. Result formats that want to print zero result output can override the method by calling the parent method with printnoresults=True.
Comment 1 John Morton 2011-03-06 06:24:49 UTC
*** Bug 27638 has been marked as a duplicate of this bug. ***
Comment 2 p858snake 2011-04-30 00:09:55 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 3 Sumana Harihareswara 2011-12-23 18:17:59 UTC
Adding "need-review" keyword to indicate patch awaits review.
Comment 4 Jeroen De Dauw 2011-12-23 18:37:42 UTC
I agree w/ the reasoning here, and in fact wanted to make such changes myself at some point. Patch probably needs some modifications to work properly w/ 1.7 and later though.

Will look at this after 1.7 rel when I find the time.
Comment 5 Jeroen De Dauw 2013-01-08 00:01:14 UTC
This should definitely be fixed in 1.8 If ay part of the problem is still there, please reopen.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links