Last modified: 2014-09-23 23:13:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29857, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27857 - Content (including categories) not showing on file redirects
Content (including categories) not showing on file redirects
Status: NEW
Product: MediaWiki
Classification: Unclassified
Categories (Other open bugs)
1.17.x
All All
: Normal minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/w/index.php?t...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-05 00:17 UTC by OlEnglish
Modified: 2014-09-23 23:13 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch to make article handle file redirects (952 bytes, patch)
2011-03-05 02:48 UTC, Bawolff (Brian Wolff)
Details

Description OlEnglish 2011-03-05 00:17:38 UTC
When adding any category to a redirect page in the File: namespace, the category name does not display in the page's bottom "Categories" box, although the page itself does get added to the category.

In the given example URL, the page is in [[Category:Test category]], and when you go to the category page "Category:Test category" it is there, but on the redirect page itself the category is not showing. ("Category:Test category" is a non-existent category but that doesn't matter, it's the same for any category).

To reproduce, simply: Go to any file redirect using [[Special:RandomRedirect/File]], and try adding a category to the page, either using Hotcat or by manually editing the page.

This was supposed to be fixed along with [[bugzilla:23851]] in the new 1.17 release but I guess it was overlooked.
Comment 1 Bawolff (Brian Wolff) 2011-03-05 02:48:33 UTC
Created attachment 8247 [details]
patch to make article handle file redirects

Seems to be caused by ImagePage.php overriding Article.php without really any reason to. This patch seems to fix it, but I'm not sure whats really going on in Article.php or what consequences this might have or why code was duplicated between Article.php and ImagePage.php, so someone who knows whats going on should have a look.
Comment 2 Rd232 2012-04-09 12:07:17 UTC
Renaming to clarify that the problem is not limited to categories: *no* content is displayed on file redirects.
Comment 3 Rd232 2012-04-09 12:13:46 UTC
Additional: one use for file redirects is to allow transclusion of an "always-up-to-date" link. Basically, individual files should be stable: File:African borders 2011.jpg should always show the 2011 borders, etc. If people want to transclude a "current African borders" file, that should be a redirect: File:current African borders.jpg, which can be redirected to whatever the current file is for that series, so in 2012 it can be changed to point to File:African borders 2012.jpg, etc. 

Now, ideally, a template on the redirect would explain matters, but because file redirects don't show any non-redirect content that's not possible at the moment.
Comment 4 Sumana Harihareswara 2012-05-25 02:21:49 UTC
Brian, are you interested in submitting this into Gerrit?
Comment 5 Bawolff (Brian Wolff) 2012-07-30 14:42:28 UTC
(In reply to comment #4)
> Brian, are you interested in submitting this into Gerrit?

Interesting, I did not recieve bug spam for this, and just happened to stumble upon this by accident.

Generally if I have a patch on a bug its because I think there's something wrong with my patch. I wrote this one over a year ago, so will have to re-look at it at some point.
Comment 6 John Mark Vandenberg 2014-05-10 07:49:46 UTC
As it has been a while, I have retested this, and it is still happening.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links