Last modified: 2005-09-02 04:59:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4784, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 2784 - Extension ImageLink.php needs amendment for >= 1.5beta3 version


Summary:	Extension ImageLink.php needs amendment for >= 1.5beta3 version

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:	787
Blocks:
	Show dependency tree / graph

Reported:	2005-07-10 09:01 UTC by T. Gries
Modified:	2005-09-02 04:59 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
proposed extension (file as extension/ImageLink.php ) (1.74 KB, text/plain) 2005-07-10 14:16 UTC, T. Gries	Details
Add an attachment (proposed patch, testcase, etc.)

Description T. Gries 2005-07-10 09:01:04 UTC

The extension implements free links (internal or external) over (internal)
images <imagelink>internalimage.png | internallink_or_externallink | alt
text</imagelink>

Due to a change in constant definition URL_PROTOCOLS [2] on 20050708, the small
extension [1] needs amendement

patch
if( preg_match( '/^(' . URL_PROTOCOLS . '):/', $linkTarget ) ) {

to
if( preg_match( '/^(' . URL_PROTOCOLS . ')/', $linkTarget ) ) {

i.e. delete the ":"


[1] http://leuksman.com/extensions/ImageLink.phps
[2]
r1=1.474&r2=1.475&f=h">http://cvs.defau.lt/cvsweb.cgi/phase3/includes/Parser.php.diff?r1=1.474&r2=1.475&f=h

Comment 1 T. Gries 2005-07-10 14:16:53 UTC

Created attachment 690 [details]
proposed extension (file as extension/ImageLink.php )

Comment 2 Brion Vibber 2005-09-02 04:59:55 UTC

ImageLink isn't included in our CVS, and I've made a similar change to the code on my 
private wiki, so considering this FIXED.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links