Last modified: 2005-09-02 04:59:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2784 - Extension ImageLink.php needs amendment for >= 1.5beta3 version
Extension ImageLink.php needs amendment for >= 1.5beta3 version
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on: 787
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-10 09:01 UTC by T. Gries
Modified: 2005-09-02 04:59 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
proposed extension (file as extension/ImageLink.php ) (1.74 KB, text/plain)
2005-07-10 14:16 UTC, T. Gries
Details

Description T. Gries 2005-07-10 09:01:04 UTC
The extension implements free links (internal or external) over (internal)
images <imagelink>internalimage.png | internallink_or_externallink | alt
text</imagelink>

Due to a change in constant definition URL_PROTOCOLS [2] on 20050708, the small
extension [1] needs amendement

patch
if( preg_match( '/^(' . URL_PROTOCOLS . '):/', $linkTarget ) ) {

to
if( preg_match( '/^(' . URL_PROTOCOLS . ')/', $linkTarget ) ) {

i.e. delete the ":"


[1] http://leuksman.com/extensions/ImageLink.phps
[2]
r1=1.474&r2=1.475&f=h">http://cvs.defau.lt/cvsweb.cgi/phase3/includes/Parser.php.diff?r1=1.474&r2=1.475&f=h
Comment 1 T. Gries 2005-07-10 14:16:53 UTC
Created attachment 690 [details]
proposed extension (file as extension/ImageLink.php )
Comment 2 Brion Vibber 2005-09-02 04:59:55 UTC
ImageLink isn't included in our CVS, and I've made a similar change to the code on my 
private wiki, so considering this FIXED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links