Last modified: 2012-11-01 18:30:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29764, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27764 - PHP Notices in data['view_urls'] items in skins/Vector.php
PHP Notices in data['view_urls'] items in skins/Vector.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.18.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-27 15:34 UTC by Sam Reed (reedy)
Modified: 2012-11-01 18:30 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-02-27 15:34:44 UTC
-rakkaus/#mediawiki-i18n- (1 lines skipped) [27-Feb-2011 15:30:45] PHP Notice:  Undefined index:  text in /www/w/skins/Vector.php on line 367

Seen on TW
Comment 1 Krinkle 2011-03-09 23:08:08 UTC
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/Vector.php?view=markup#l360


                        <li<?php echo $link['attributes'] ?>><span><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo (array_key_exists('img',$link) ?  '<img src="'.$link['img'].'" alt="'.$link['text'].'" />' : htmlspecialchars( $link['text'] ) ) ?></a></span></li>


$link['text']
Comment 2 Sam Reed (reedy) 2011-03-20 20:04:44 UTC
[22:02:30] -rakkaus:#mediawiki-i18n- (1 lines skipped) [20-Mar-2011 20:01:42] PHP Notice:  Undefined index: text in /www/w/skins/Vector.php on line 369



Seems to have moved a line or 2 ;)
Comment 3 Krinkle 2011-03-22 21:44:34 UTC
Fixed in r84565, 84566.
Comment 4 Niklas Laxström 2011-04-22 10:19:06 UTC
PHP Notice:  Undefined index: href in /www/w/skins/Vector.php on line 369

Should we track where this data comes from?
Comment 5 Krinkle 2011-06-11 21:55:33 UTC
Yes, I believe it comes from an extension that passes invalid links to Vector.

btw, that's not entirely the same notice as the one this bug was about, so I've widen the summary.

Not sure how much this would break, but perhaps there should be a requirement for which items it needs and otherwise some central (instead of inline) defaults otherwise.
Comment 6 Bugmeister Bot 2011-08-19 19:12:57 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 7 Bartosz Dziewoński 2012-11-01 18:30:29 UTC
The last issue here seems to be a dupe of 38334. Marking this as resolved fixed (as the primary issue was dealt with).
Comment 8 Bartosz Dziewoński 2012-11-01 18:30:42 UTC
Bug 38334, that is.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links