Last modified: 2011-03-15 17:42:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29750, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27750 - Save redirects to wrong diff
Save redirects to wrong diff
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Rob Lanphier
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-26 20:27 UTC by Bergi
Modified: 2011-03-15 17:42 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bergi 2011-02-26 20:27:24 UTC
I'm not sure whether this bug belongs to the edit process or to diff handling.

I just edited a template, and when I submitted it I got redirected to http://de.wikipedia.org/w/index.php?title=Vorlage:Navigationsleiste_Musik&oldid=85800660&diff=cur&diffonly=0&shownotice=1,
I guess to sight my change. Thats OK, but the diff is strange: the older version shown just is the same as the newer (current) one, the edit comment, the oldid-link: all the same.

I guess the correct link would be without the oldid parameter, or with the oldid parameter set to the previous revision.
Comment 1 Bawolff (Brian Wolff) 2011-02-26 20:29:47 UTC
I'm going to go with flagged revs fault, since the extension is the thing redirecting you.
Comment 2 Aaron Schulz 2011-02-26 21:21:03 UTC
So the oldid parameter is for the revision just made?
Comment 3 Bergi 2011-02-26 21:37:26 UTC
Exactly. I'm sorry that I didnt' point it out clearly.
Comment 4 Aaron Schulz 2011-02-26 22:27:22 UTC
Does this occur regularly or randomly?

I can't see how this happens in injectPostEditURLParams()
Comment 5 Aaron Schulz 2011-02-27 02:00:56 UTC
According to the history, your change was sighted automatically.
Comment 6 Aaron Schulz 2011-02-27 08:22:36 UTC
(In reply to comment #4)
> Does this occur regularly or randomly?
> 
> I can't see how this happens in injectPostEditURLParams()

Actually looking at getLatestRevID(), it doesn't handle cache/FOR_UPDATE well...
Comment 7 Aaron Schulz 2011-02-27 19:58:50 UTC
Fixed in r82904.
Comment 8 Bergi 2011-03-15 17:27:15 UTC
Please set the fix live, I just got the same error again (http://de.wikipedia.org/w/index.php?title=Vorlage:Infobox_PKW-Modell&oldid=86490550&diff=cur&diffonly=0&shownotice=1).
Might it have something to do with the namespace, I only got these problems after editing a template?
Comment 9 Aaron Schulz 2011-03-15 17:42:37 UTC
The bug status isn't based on what's live (unless it's a site request).

Also, this fix can't be backported by itself. Other changes and code review are needed. The only thing that could be done is a live-hack, like calling $this->article->getTitle()->resetArticleId(0) before fetching the latest revision to clear the process cache.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links