Last modified: 2010-05-15 15:38:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2773 - The print mode of page is not shown as RTL on RTL wikis.
The print mode of page is not shown as RTL on RTL wikis.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.5.x
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Rotem Liss
http://he.wikipedia.org/
:
Depends on:
Blocks: rtl
  Show dependency treegraph
 
Reported: 2005-07-09 15:57 UTC by assafkat
Modified: 2010-05-15 15:38 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (5.27 KB, text/plain)
2005-08-10 13:10 UTC, Rotem Liss
Details
A non-corrupted patch (?) (4.53 KB, patch)
2005-08-10 14:25 UTC, Rotem Liss
Details

Description assafkat 2005-07-09 15:57:31 UTC
The print mode of page is shown as LTR, not as RTL
Comment 1 Rotem Liss 2005-08-10 13:04:04 UTC
It is impossible the page is LTR - firstly, the attribute "dir=rtl" is wrote in
the tag HTML, secondly, the attribute "direction: rtl;" is wrote in "rtl.css"
and in the dynamically-created CSS file "monobook.css", thirdly, Mozilla's DOM
Inspector says the "direction" is "rtl" in the HTML tag, fourthly, the text is
shown with "text-align: left", but with "direction: rtl", and finally, the whole
page is shown from the Right to Left.

However, I've checked the element "p" in one of the cells shown from the left,
and saw it is "text-align: left".

Shortly, the setting "text-align: left;" for #content in "commonPrint.css".
Please note there is NO setting like that in the regular style (which does not
set "text-align" at all), and that removing this setting fixes the problem AND
does not create any problem in the LTR pages.

I will try to create a patch shortly.
Comment 2 Rotem Liss 2005-08-10 13:10:24 UTC
Created attachment 767 [details]
Patch

Please note I've just copied the file from the Hebrew Wikipedia and removed the
line, and don't know whether I've created the patch correctly or the file is
corrupted. I also don't know whether the file is up-to-date.
Comment 3 assafkat 2005-08-10 13:11:49 UTC
I don't know what the problem but the print page like
http://he.wikipedia.org/w/index.php?title=%D7%97%D7%91%D7%A8%D7%99%D7%9D&printable=yes
is shown with left alignment instead of right one.
Comment 4 Rotem Liss 2005-08-10 13:15:57 UTC
(In reply to comment #3)
> I don't know what the problem but the print page like
>
http://he.wikipedia.org/w/index.php?title=%D7%97%D7%91%D7%A8%D7%99%D7%9D&printable=yes
> is shown with left alignment instead of right one.

This patch would fix it.
Comment 5 Zigger 2005-08-10 13:53:51 UTC
(Please add wikibugs-l@wikipedia.org to the CC list when assigning a bug.)
Comment 6 Rotem Liss 2005-08-10 14:25:37 UTC
Created attachment 768 [details]
A non-corrupted patch (?)

I'm trying to create a patch, although I don't fully understand the headers.
Comment 7 Rotem Liss 2005-10-15 10:27:33 UTC
Well, what about checking in the patch? I've tried to get one the E-mail address
of the developers, but I failed. Where can I get it?
Comment 8 assafkat 2005-10-15 10:30:36 UTC
The bug wasn't fixed. The page like
http://he.wikipedia.org/w/index.php?title=%D7%9E%D7%95%D7%97%D7%9E%D7%93_%D7%90-%D7%93%D7%95%D7%A8%D7%94&printable=yes
is alredy at LTR
Comment 9 Rotem Liss 2005-10-15 10:32:43 UTC
(In reply to comment #8)
> The bug wasn't fixed. The page like
>
http://he.wikipedia.org/w/index.php?title=%D7%9E%D7%95%D7%97%D7%9E%D7%93_%D7%90-%D7%93%D7%95%D7%A8%D7%94&printable=yes
> is alredy at LTR

I know. The patch which fixes it is yet not checked into the system.
Comment 10 Rob Church 2005-10-15 13:51:29 UTC
The patch will be applied and the changes committed to CVS when:

1. A developer has time to review the patch
2. That developer determines that the patch works, and doesn't break anything else
3. The developer commits the patch

You won't notice the changes on Wikimedia's wikis until the MediaWiki software
is synchronised; again, another developer has to do this, and be confident that
nothing has been introduced to the CVS tree which could cause problems for the
project.

Patience is a virtue.
Comment 11 Brion Vibber 2005-10-15 19:15:24 UTC
The "patch" seems to be an entire copy of commonPrint.css, from 
some old version which removes a bunch of stuff that's in there 
now. Quickly skimming a diff I don't see anything relevant to RTL.
Comment 12 Brion Vibber 2005-10-15 19:15:48 UTC
Removing patch keywords since there is no patch.
Comment 13 Rotem Liss 2005-10-16 13:34:51 UTC
(In reply to comment #11)
> The "patch" seems to be an entire copy of commonPrint.css, from 
> some old version which removes a bunch of stuff that's in there 
> now. Quickly skimming a diff I don't see anything relevant to RTL.
> 

Well, it is a very simple change: removing the line "text-align: left". That's
the change should be done. And I don't know where is the CVS, so I cannot update
the patch to change the CVS version (or something like that), but the only
change is removing this line. (By the way, the problem is not LTR but the align
to the left: you can see it in the linked page.)
Comment 14 Brion Vibber 2005-10-16 20:54:45 UTC
Ahh, now I see. Thanks!

Fix applied on CVS HEAD and REL1_5.
You may need to force-reload style sheets to see the fix in place.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links