Last modified: 2011-03-13 18:04:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 27723 - Error warnings of SyntaxHighlighting should be in user language, not content language
Error warnings of SyntaxHighlighting should be in user language, not content ...
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Lowest normal (vote)
: ---
Assigned To: X!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-25 21:36 UTC by The Evil IP address
Modified: 2011-03-13 18:04 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description The Evil IP address 2011-02-25 21:36:01 UTC
At the moment, Geshi warnings when entering a wrong language, e.g. <source lang="jvascript"> always shows the warnings in the content language of the wiki, which is bad for usability on multilingual wikis like the Commons.

It's a trivial fix where only the "wfMsgForContent" function in http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php?revision=82801&view=markup have to be replaced with "wfMsg" functions.
Comment 1 Niklas Laxström 2011-02-25 21:37:39 UTC
The warning is saved with article text in the database. It can't vary per language.
Comment 2 Max Semenik 2011-02-25 21:39:08 UTC
Well, we still can disable caching on such pages. Well, we can't do this on Wikimedia.
Comment 3 Bawolff (Brian Wolff) 2011-02-25 22:50:33 UTC
 (In reply to comment #2)
> Well, we still can disable caching on such pages. Well, we can't do this on
> Wikimedia.

Well we could just make the cache vary on userlanguage when the message is outputted, like we do for {{int:, but I don't think that's likely to happen.

Marking wontfix per Niklas's comment.
Comment 4 Niklas Laxström 2011-02-26 07:45:31 UTC
Making the cache vary on user language (what is already done!) does not help, since the error text is literally in the page source and not dynamic. I'm not saying it can't be done, but general infrastructure for reporting errors in wikitext would be nice.
Comment 5 db [inactive,noenotif] 2011-02-26 11:38:26 UTC
The error message is not stored as literally text in the database, only in the cache. The parser never change wikitext before saving to the database. It would contain <source lang="jvascript"> in old version of a page.
Comment 6 Niklas Laxström 2011-02-26 11:39:58 UTC
Yes I'm wrong. Plain wfMsg() wouldn't work though.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links