Last modified: 2011-03-10 20:57:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29703, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27703 - CR should parse 'bug#25848'
CR should parse 'bug#25848'
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-25 09:40 UTC by Antoine "hashar" Musso (WMF)
Modified: 2011-03-10 20:57 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2011-02-25 09:40:15 UTC
We might want to parse and render the syntax 'bug#xxxx'

Example usage: r82784
Comment 1 Sam Reed (reedy) 2011-02-25 10:40:55 UTC
		$text = preg_replace_callback( '/\bbug #?(\d+)\b/i',
			array( $this, 'messageBugLink' ), $text );


That apparently works in code comments ^

		if ( preg_match( '/\b(bug #?(\d+)|\$[we]g[0-9a-z]{3,50})\b/i', $summary ) ) {
			return true;
		}

For Code Release Notes ^

		if ( preg_match_all( '/\bbug (\d+)\b/', $this->message, $m ) ) {

^ Comments

r82786 adds one for comments. Not sure if it's used anywhere else

-		if ( preg_match_all( '/\bbug (\d+)\b/', $this->message, $m ) ) {
+		if ( preg_match_all( '/\bbug #?(\d+)\b/', $this->message, $m ) ) {

So we also need to make the space optional too...

AFAIK, the bug #1234 already worked?
Comment 2 Sam Reed (reedy) 2011-02-25 10:42:01 UTC
Yeah, look at r82696, that does bug#1234

I'll make the spaces option in a few
Comment 3 Sam Reed (reedy) 2011-02-25 10:57:10 UTC
r82788

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links