Last modified: 2011-08-24 16:45:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29678, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27678 - No result given when searching using "offset" option in Special:IndexPages
No result given when searching using "offset" option in Special:IndexPages
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://fr.wikisource.org/w/index.php?...
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-24 12:48 UTC by Yann Forget
Modified: 2011-08-24 16:45 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for Special:IndexPages (3.03 KB, patch)
2011-08-21 11:35 UTC, Beau
Details

Description Yann Forget 2011-02-24 12:48:19 UTC
This page is empty, however more indexes should be shown: http://fr.wikisource.org/w/index.php?title=Sp%C3%A9cial:IndexPages&limit=500&key=BNF

BTW this doesn't work either: http://fr.wikisource.org/w/index.php?title=Sp%C3%A9cial:IndexPages&limit=500&offset=100&key=BNF
Comment 1 Yann Forget 2011-02-24 12:50:05 UTC
Actually the last URL works, but not http://fr.wikisource.org/w/index.php?title=Sp%C3%A9cial:IndexPages&limit=500&offset=500&key=BNF
Comment 2 Yann Forget 2011-02-24 12:54:17 UTC
It doesn't work when offset >= limit, otherwise it works.
Comment 3 Yann Forget 2011-02-24 13:11:15 UTC
In addition, some pages do not appear in the results. For example, this page contains the text BNF but doesn't appear in the search: http://fr.wikisource.org/wiki/Livre:Barchou_de_Penho%C3%ABn_-_Histoire_de_la_conqu%C3%AAte_de_l%E2%80%99Inde_par_l%E2%80%99Angleterre,_tome_1.djvu
Comment 4 Yann Forget 2011-04-03 07:55:31 UTC
Any news about this?
Comment 5 Yann Forget 2011-05-17 17:04:54 UTC
May be related to this, there is a bug when searching from http://fr.wikisource.org/w/index.php?title=Sp%C3%A9cial:IndexPages&limit=100&offset=100 :

E. g. searching for "Rousseau" leads to 
http://fr.wikisource.org/w/index.php?key=Rousseau
instead of http://fr.wikisource.org/wiki/Sp%C3%A9cial:IndexPages?key=Rousseau
Comment 6 Beau 2011-08-21 11:35:02 UTC
Created attachment 8955 [details]
Patch for Special:IndexPages

It seems to me that version in trunk did not perform search at all.

I fixed following issues:
* Disable offset in reallyDoQuery if search was performed. So it won't be applied twice.
* List of pages is stored in $this->searchList instead of $searchList, so it will be used in getQueryInfo method.
* When no matching indexes were found the page says so, instead of displaying all indexes.
* When search button was clicked twice, user was redirected to main page.
* When search button was clicked twice, the previous page limit was lost.
* isCacheable returns false, due to search capabilities.
Comment 7 Beau 2011-08-24 16:45:11 UTC
Applied by John Du Hart in r95347.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links