Wikimedia Bugzilla is closed!

Hi!

I have a proposition to fix line 196 as it will fail if wfLocalFile(...) fails to return an object. In my case, it was due to an odd character in the file name.

Some people might want it to fail with incompatible filenames. In my case, importing images from Wikipedia, I don't want it to stop at every broken filename. So I propose the following, and maybe someone can add some commandline option such as "--skip-unreadable" or similar.


                        $file = wfLocalFile( $filename );
                        if (!$file) {
                           $this->log ("cannot be read: $filename");
                        } else {
                                if ( !$file->recordUpload( '', '(recovered file$
                                false, $timestamp ) )
                                {
                                        $this->log( "Error uploading file $full$
                                        return;
                                }
                        }