Last modified: 2011-02-23 18:19:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29637, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27637 - Whitespace is included between transcluded pages in Proofread
Whitespace is included between transcluded pages in Proofread
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: ThomasV
https://secure.wikimedia.org/wikisour...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-22 18:11 UTC by Beau
Modified: 2011-02-23 18:19 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Beau 2011-02-22 18:11:15 UTC
PageA contains: "This is a wo"
PageB contains: "rd between pages"

Transcluding those pages using <pages> tag results in a text: "This is a wo rd between pages", but expected text is: "This is a word between pages".
Comment 1 ThomasV 2011-02-23 08:00:29 UTC
this is expected behaviour
Comment 2 Beau 2011-02-23 16:11:02 UTC
This _was_ expected behaviour? Older versions did not include that whitespace, so on pl.wikisource pages contain exact text, that appears on the scans - it makes sense. Now divided words have space in the middle, so we need to review our all pages, and correct that moving word to one of the pages. It is counterintuitive...
Comment 3 ThomasV 2011-02-23 17:00:53 UTC
this is very strange. are you sure ?
Comment 4 Beau 2011-02-23 17:07:21 UTC
I am sure, because we have lots of pages, which have divided words. They were always glued together by <pages> without whitespaces. If someone wanted to change that behaviour, it could have been done simply by adding whitespace to [[MediaWiki:Proofreadpage pagenum template]].
Comment 5 teukrosannon 2011-02-23 17:10:16 UTC
Yes, we are completely sure, older versions did not inlcuded whitespaces. We have over 20 000 pages with exact text, down to the spaces. Examples:

http://pl.wikisource.org/wiki/Strona:PL_Gloger-Encyklopedja_staropolska_ilustrowana_T.2_123.jpg

and 

http://pl.wikisource.org/wiki/Strona:PL_Gloger-Encyklopedja_staropolska_ilustrowana_T.2_124.jpg

As you can see, whitespaces were definitely not expected on those pages.
Comment 6 ThomasV 2011-02-23 17:58:57 UTC
I just dicussed with ankry on IRC. Apparently there was a bug in the software, that caused whitespace not to be added when pages are numbered manually. I was not aware of it. On other wikisources, manual numbering of pages is almost never used in conjunction with <pages/>, so this bug went unnoticed.

I do not think that we should revert to the former behaviour; it does not make sense to keep incompatibilities. in addition, it is cumbersome to add &#32; at the end of all pages. pl.ws is a small wiki. we can fix it with a robot.
Comment 7 Beau 2011-02-23 18:04:33 UTC
I would like to avoid using a bot. Maybe there can be introduced configuration variable, which allows to switch to older behaviour? Or if it went unnoticed, just leave the old behaviour and add whitespace to [[MediaWiki:Proofreadpage pagenum template]] on projects where it is needed.
Comment 8 ThomasV 2011-02-23 18:10:13 UTC
[[MediaWiki:Proofreadpage pagenum template]] is for page numbers and it might be deprecated in the future; better don't use it for something else.
Comment 9 Beau 2011-02-23 18:15:33 UTC
I hate writing ugly pieces of code, but if there is no other way, we will just use javascript to remove that whitespace for now. It won't work for every user, but I think it is better to keep exact text on pages without using additional templates or other wikicode solutions.
Comment 10 ThomasV 2011-02-23 18:19:41 UTC
if the absence of &#32; currently predicts the need for a hyphenation template, you should not remove it ; it can be used by a robot to add the template where it is needed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links